-
Notifications
You must be signed in to change notification settings - Fork 67
[native_assets_builder] Lock the build directory - fixes #1399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -73,6 +80,8 @@ Future<T> _runUnderFileLock<T>( | |||
); | |||
printed = true; | |||
} | |||
// Don't busy wait, give the CPU some rest. | |||
// Magic constant taken from flutter_tools for startup lock. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hixie I don't see any documentation on flutter/flutter#4476 for how the magic constant was chosen. Would you happen to remember why 50 milliseconds?
PR HealthBreaking changes ✔️Details
API leaks ✔️DetailsThe following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️Details
All source files should start with a license header. Unrelated files missing license headers
Package publish validation ✔️Details
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
auto label is removed for dart-lang/native/1399, due to - The status or check suite health / changelog / run has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Addresses these comments: