Skip to content

[native_assets_builder] If dill file is equal, don't invalidate cache #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 10, 2024
Merged

[native_assets_builder] If dill file is equal, don't invalidate cache #1789

merged 3 commits into from
Dec 10, 2024

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Dec 6, 2024 •
edited
Loading

Only invalidate hook invocation cache if the compiled hook changed, not if the Dart source change but the compiled hook does not.

we can skip running the hook if none of the hook-reported deps changed and the hook.dill didn't change

Closes: #1780 (comment)

@dcharkes dcharkes requested a review from mkustermann December 6, 2024 14:35
Base automatically changed from nab-remove-dry-run to main December 10, 2024 09:15
@dcharkes dcharkes merged commit da5dc14 into main Dec 10, 2024
21 checks passed
@dcharkes dcharkes deleted the depend-on-dill branch December 10, 2024 09:15
@dcharkes
Copy link
Collaborator Author

Thanks @mkustermann!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkustermann mkustermann mkustermann approved these changes

Assignees
No one assigned
Labels
package:hooks_runner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcharkes @mkustermann