Skip to content

[native_assets_builder] Consume the new .dart_tool/package_graph.json #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

dcharkes
Copy link
Collaborator

Closes: #1968

Our current workflow with rolling into Flutter tools requires the Dart SDK constraint to be a stable Dart release. This means the tests are also run against a stable Dart release. So keep the fallback behavior. (The JSON structure that we use is identical.)

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

Coverage Status

coverage: 87.429% (-0.001%) from 87.43%
when pulling 3e855ba on package-graph
into ae32a51 on main.

Copy link

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: The json is not really identical.

For the root package (deps --json)['dependencies'] wil include the dev_dependencies, while (package_graph.json)['dependencies'] only includes the non-dev dependencies.

@dcharkes
Copy link
Collaborator Author

Users should not be using dev-dependencies in their hooks, so that's perfect. 👍

@dcharkes dcharkes merged commit f086776 into main Feb 27, 2025
32 checks passed
@dcharkes dcharkes deleted the package-graph branch February 27, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native_assets_builder] dart pub deps --json and .package_config.json could disagree
3 participants