Skip to content

Conversation

@dcharkes
Copy link
Collaborator

@github-actions
Copy link

github-actions bot commented Apr 23, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
native_assets_cli Breaking 0.16.0 0.17.0-wip 0.17.0 ✔️
API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@auto-submit auto-submit bot removed the autosubmit label Apr 23, 2025
@auto-submit
Copy link

auto-submit bot commented Apr 23, 2025

autosubmit label was removed for dart-lang/native/2223, because - The status or check suite health / changelog / run changelog health check has failed. Please fix the issues identified (or deflake) before re-applying this label.

Copy link
Contributor

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit
Copy link

auto-submit bot commented Apr 23, 2025

autosubmit label was removed for dart-lang/native/2223, because - The status or check suite health / changelog / run changelog health check has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dcharkes dcharkes merged commit e50bc14 into main Apr 23, 2025
66 of 69 checks passed
@dcharkes dcharkes deleted the json-cleanup-assetsforlinking branch April 23, 2025 07:58
@coveralls
Copy link

Coverage Status

coverage: 77.475% (-0.08%) from 77.554%
when pulling 3d50dde on json-cleanup-assetsforlinking
into 24f71bf on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants