[jni] Remove hack in findClass and fix call sites#3180
Open
imshubham22apr-gif wants to merge 1 commit intodart-lang:jni_extension_typesfrom
Open
[jni] Remove hack in findClass and fix call sites#3180imshubham22apr-gif wants to merge 1 commit intodart-lang:jni_extension_typesfrom
imshubham22apr-gif wants to merge 1 commit intodart-lang:jni_extension_typesfrom
Conversation
imshubham22apr-gif
force-pushed
the
fix-findclass-hack
branch
from
0d0c928 to
60b2e20
Compare
Contributor
|
@imshubham22apr-gif #3174 is a follow up to a PR that hasn't landed yet. Please wait for that to land before you try to fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the temporary hack in
Jni.findClassthat was stripping 'L' and ';' from class signatures. To support this, I've updatedJType.jClassto handle the signature stripping instead, ensuring that only binary class names are passed for lookup.Related Issues
Fixes #3174
PR Checklist
dart tool/ci.dart --alllocally.