Skip to content

Workflow cleanups #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 5, 2023
Merged

Workflow cleanups #846

merged 10 commits into from
Dec 5, 2023

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Dec 4, 2023

Switch to using pubspec_overrides.yaml files instead of manually parsing and writing pubspec files. This makes local development easier while still testing the published version in CI. Implementing dart-lang/pub#4076 would simplify this even further.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mosuem mosuem changed the title Switch to pub overrides Workflow cleanups Dec 4, 2023
@mosuem mosuem requested a review from dcharkes December 5, 2023 14:04
@mosuem mosuem marked this pull request as ready for review December 5, 2023 14:04
Copy link
Collaborator

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split the PR in two, do the health thing in another PR? (Please add documentation to the health thing, I've never heard of it.)

I like the idea that the default developer experience is path dependencies. That makes it easier to make changes across multiple packages. I don't think that this will fully work with the tests though. When running the tests that copy testing packages to temp folders, the overrides inside those folders have paths that are no longer correct? (But the CI is green?!)

@mosuem
Copy link
Member Author

mosuem commented Dec 5, 2023

The CI was green as the overrides were not copied, so the packages were resolved via pub. Now the overrides are copied and point to the right package folders.

@dcharkes
Copy link
Collaborator

dcharkes commented Dec 5, 2023

The PR description is out of date.

Please expand the description a bit with #846 (comment) so we can understand our own changes in 3 years. 😄

@@ -0,0 +1,6 @@
import 'dart:io';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we have 0 package dependencies in this script, so no pubspec is needed? it feels a bit weird though.

Does it mean this script always has to be the latest language version for example?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never use pubspecs on scripts :D It just means no restrictions on the SDK used, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which could mean it stops working on Dart 4.0 ?

Fine with me either way. 4.0 is far out =P

@mosuem mosuem merged commit a0949f5 into main Dec 5, 2023
@mosuem mosuem deleted the switchToPubOverrides branch December 5, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants