-
Notifications
You must be signed in to change notification settings - Fork 68
Workflow cleanups #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow cleanups #846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we split the PR in two, do the health thing in another PR? (Please add documentation to the health thing, I've never heard of it.)
I like the idea that the default developer experience is path dependencies. That makes it easier to make changes across multiple packages. I don't think that this will fully work with the tests though. When running the tests that copy testing packages to temp folders, the overrides inside those folders have paths that are no longer correct? (But the CI is green?!)
pkgs/native_assets_builder/test/data/cyclic_package_1/pubspec_overrides.yaml
Outdated
Show resolved
Hide resolved
pkgs/native_assets_cli/example/native_add_library/pubspec_overrides.yaml
Outdated
Show resolved
Hide resolved
The CI was green as the overrides were not copied, so the packages were resolved via pub. Now the overrides are copied and point to the right package folders. |
The PR description is out of date. Please expand the description a bit with #846 (comment) so we can understand our own changes in 3 years. 😄 |
@@ -0,0 +1,6 @@ | |||
import 'dart:io'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we have 0 package dependencies in this script, so no pubspec is needed? it feels a bit weird though.
Does it mean this script always has to be the latest language version for example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never use pubspecs on scripts :D It just means no restrictions on the SDK used, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which could mean it stops working on Dart 4.0 ?
Fine with me either way. 4.0 is far out =P
Switch to using
pubspec_overrides.yaml
files instead of manually parsing and writing pubspec files. This makes local development easier while still testing the published version in CI. Implementing dart-lang/pub#4076 would simplify this even further.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.