Skip to content

Don’t include lib/src files in package analysis #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2017
Merged

Don’t include lib/src files in package analysis #12

merged 1 commit into from
Jun 2, 2017

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Jun 2, 2017

Closes #11

@kevmoo kevmoo requested a review from isoos June 2, 2017 05:16
isoos
isoos approved these changes Jun 2, 2017
View reviewed changes
Copy link
Collaborator

@isoos isoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a follow-up refactor to make it clear that _scanPackage is only meant to be called in the initial package dir, and subsequent dependencies need to scan the lib/src too.

@kevmoo kevmoo merged commit 0e97857 into master Jun 2, 2017
@kevmoo kevmoo deleted the i11_no_lib_impl branch June 2, 2017 05:55
@jonasfj jonasfj mentioned this pull request Jul 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isoos isoos isoos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevmoo @isoos