Skip to content

Separate homepage and repository for a package #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jan 9, 2018

  • introduces a new repository field in pubspec.yaml
  • if only homepage is specified and it is a known repository url, it will be displayed as "Repository" and not as "Homepage"
  • if both are specified, both will be displayed

Deployed in staging, a few examples:

@isoos
Copy link
Collaborator Author

isoos commented Jan 9, 2018

Fixes #842

Copy link
Contributor

@jakobr-google jakobr-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to discuss internally before we add a field to pubspec

@kevmoo
Copy link
Member

kevmoo commented Jan 10, 2018

Chatted w/ @mit-mit about this. There is no simple fix here. Not a high priority now.

@kevmoo kevmoo closed this Jan 10, 2018
@isoos isoos deleted the pubspec_repository branch January 11, 2018 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants