Skip to content

Snapshotted pub executables behave badly with unhandled exceptions #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DartBot opened this issue Jun 5, 2015 · 2 comments
Closed

Snapshotted pub executables behave badly with unhandled exceptions #1232

DartBot opened this issue Jun 5, 2015 · 2 comments
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="96" height="96"hspace="10"> Issue by nex3
Originally opened as dart-lang/sdk#22076


Currently, if a snapshotted pub executable (most commonly one installed with "pub global activate") has an unhandled exception, the executable will be recompiled and re-run three times before ultimately failing. This is du to issue dart-lang/sdk#20802, which makes it impossible for the script running the executable to determine if it's up-to-date without running it, and the fact that the VM emits the same exit code for unhandled exceptions and for invalid snapshot numbers.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Thanks to dart-lang/sdk@c859d25, I now have out https://codereview.chromium.org/899373002 to fix this.


Unmarked this as being blocked by dart-lang/sdk#20802.

@DartBot DartBot added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) Fixed labels Jun 5, 2015
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Fixed in dart-lang/sdk@b97af95.


Added Fixed label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

1 participant