Skip to content

Add a facility to test whether a snapshot is up-to-date without running it #20802

Description

@nex3

The fix for issue #15982 is great, but now we also need the ability to check whether a snapshot is up-to-date without actually having to run it. Just something like "dart --is-snapshot-up-to-date <snapshot-path>" that returned a 0 or 1 exit code would be fine.

Activity

  1. nex3 commented on Jan 15, 2015

    @nex3
    MemberAuthor

    I'm increasing the priority of this. Relying on exit code detection causes serious problems for pub executables, especially since the VM emits exit code 255 for both an invalid snapshot number and an unhandled exception, so any unhandled exception in an executable causes the executable to be re-run over and over.


    Removed Priority-Unassigned label.
    Added Priority-High label.

  2. nex3 commented on Jan 15, 2015

    @nex3
    MemberAuthor

    Marked this as blocking #22076.

  3. iposva-google commented on Feb 5, 2015

    @iposva-google
    Contributor

    As of r43505 the VM returns exit code 253 if an API error is triggered. This generally happens when loading an invalid snapshot.


    Set owner to @iposva-google.
    Added Fixed label.

  4. nex3 commented on Feb 5, 2015

    @nex3
    MemberAuthor

    Having a different error code helps somewhat, but it doesn't solve the issue. This will still break if the Dart code itself emits exit code 253, and it still requires that we try to run the snapshot to determine whether it's up-to-date, which means we show users a confusing error message (20784).


    Added Triaged label.

  5. nex3 commented on Feb 6, 2015

    @nex3
    MemberAuthor

    Unmarked this as blocking #22076.

  6. nex3 commented on Feb 6, 2015

    @nex3
    MemberAuthor

    Marked this as blocking #22308.

  7. kasperl commented on Mar 20, 2015

    @kasperl

    Added this to the 1.10 milestone.

  8. iposva-google commented on Apr 17, 2015

    @iposva-google
    Contributor

    Removed this from the 1.10 milestone.
    Added this to the 1.11 milestone.

  9. added
    P1A high priority bug; for example, a single project is unusable or has many test failures
    area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
    on Apr 17, 2015
  10. added this to the 1.11 milestone on Apr 17, 2015
  11. added this to the 1.12 milestone on Jun 17, 2015
  12. 6 remaining items

  13. removed their assignment
    on May 31, 2016
  14. removed this from the milestone on Mar 20, 2018
  15. mraleph commented on Apr 24, 2018

    @mraleph
    Member

    This feature request has been slowly shifting from milestone to milestone with nothing happening to it. Closing it as stale for now.

  16. nex3 commented on Apr 24, 2018

    @nex3
    MemberAuthor

    This is still something I would very much like for pub!

  17. reopened this on Apr 24, 2018
  18. removed
    closed-obsoleteClosed as the reported issue is no longer relevant
    P1A high priority bug; for example, a single project is unusable or has many test failures
    on Apr 24, 2018
  19. mraleph commented on Apr 24, 2018

    @mraleph
    Member

    Okay - removing Stale marker and priority. Lets see if we can slate this to be implemented.

  20. nex3 commented on Apr 24, 2018

    @nex3
    MemberAuthor

    That would be great 😄

  21. a-siva commented on Jul 13, 2018

    @a-siva
    Contributor

    Is this issue talking about a script snapshot or an application snapshot ?

  22. nex3 commented on Jul 13, 2018

    @nex3
    MemberAuthor

    Both.

  23. DanTup commented on Jul 16, 2018

    @DanTup
    Collaborator

    This might solve an issue in Flutter too (for Linux/Mac at least, haven't investigated Windows): flutter/flutter#19208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.customer-pubtype-enhancementA request for a change that isn't a bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions