Skip to content

pub build should support dart2js's --fatal-warnings flag #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DartBot opened this issue Jun 4, 2015 · 3 comments
Closed

pub build should support dart2js's --fatal-warnings flag #18

DartBot opened this issue Jun 4, 2015 · 3 comments
Assignees
@nex3
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 4, 2015

<img src="https://avatars.githubusercontent.com/u/224266?v=3" align="left" width="96" height="96"hspace="10"> Issue by johnmccutchan
Originally opened as dart-lang/sdk#23379

dart2js has this new flag:

--fatal-warnings

which will cause compilation to abort if there are any warnings.

pub build doesn't check the process exit code so it never realizes that dart2js failed.

If this worked, we could ensure that a bug in Observatory code triggers a build failure, catching our mistake earlier.
@DartBot
Copy link
Author

DartBot commented Jun 4, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3

Set owner to @nex3.
Added Area-Pub, Accepted labels.

@DartBot DartBot added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) Accepted labels Jun 4, 2015
@DartBot DartBot mentioned this issue Jun 4, 2015
Closed
@nex3 nex3 removed the Accepted label Jun 5, 2015
@nex3 nex3 added transformer type-enhancement A request for a change that isn't a bug and removed type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Dec 9, 2015
@enyo
Copy link

enyo commented Feb 15, 2017

What is the state on this? Is there a way to make pub build fail if there is a warning in dart2js?

@rwrozelle rwrozelle mentioned this issue Mar 21, 2018
Closed
@matanlurey matanlurey added the closed-not-planned Closed as we don't intend to take action on the reported issue label Mar 24, 2018
@matanlurey
Copy link
Contributor

We are no longer supporting transformers going forward, so a fix for this is not planned.

@Rushabhshroff Rushabhshroff mentioned this issue Apr 28, 2018
Closed
@BirdyF BirdyF mentioned this issue Mar 5, 2019
Closed
@faxinter faxinter mentioned this issue Mar 30, 2019
Closed
@gooking gooking mentioned this issue Sep 5, 2019
Closed
@WangZhen0908 WangZhen0908 mentioned this issue Jun 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nex3 nex3

Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nex3 @enyo @matanlurey @DartBot