Skip to content

pub build should support dart2js's --fatal-warnings flag #23379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnmccutchan opened this issue May 4, 2015 · 2 comments
Closed

pub build should support dart2js's --fatal-warnings flag #23379

johnmccutchan opened this issue May 4, 2015 · 2 comments
Assignees
@nex3

Comments

@johnmccutchan
Copy link
Contributor

dart2js has this new flag:

--fatal-warnings

which will cause compilation to abort if there are any warnings.

pub build doesn't check the process exit code so it never realizes that dart2js failed.

If this worked, we could ensure that a bug in Observatory code triggers a build failure, catching our mistake earlier.
@nex3
Copy link
Member

nex3 commented May 4, 2015

Set owner to @nex3.
Added Area-Pub, Accepted labels.

@DartBot
Copy link

DartBot commented Jun 4, 2015

This issue has been moved to dart-lang/pub#18.

@DartBot DartBot closed this as completed Jun 4, 2015
@DartBot DartBot mentioned this issue Jun 4, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nex3 nex3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nex3 @kevmoo @johnmccutchan @DartBot