-
Notifications
You must be signed in to change notification settings - Fork 229
Do not store credentials in PUB_CACHE #2999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm not 100% sure about Windows and Mac OS. But it looks like what other people are doing. Not sure if it should be roaming on Windows, and it seems using XDG on Mac OS might not be so crazy.
Feedback / input is welcome from people lots of experience on these platforms. |
Counter argument do like This is messy, and IMO we should clean it up. But until we do, perhaps it's better to just expand the mess rather than storing files in more locations. |
The
PUB_CACHE
folder is something that it makes sense to cache in CI, so storing credentials inPUB_CACHE/credentials.json
might not be ideal.On windows we prefer to use a non-roaming folder for
PUB_CACHE
, but configuration options such ascredentials.json
should probably be roaming with the user profile.See also: dart-lang/sdk#41560
The text was updated successfully, but these errors were encountered: