Skip to content

[MOB-9322] Merge Release CI Jobs Together #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Conversation

TheBuggedYRN
Copy link
Contributor

@TheBuggedYRN TheBuggedYRN commented Nov 2, 2022

Description of the change

Back in #98, a separate release job for pub was added, because Escape could no longer authenticate to pub. The authentication failure was due to this change in pub: dart-lang/pub#2999.

This PR aims at merging back the two release jobs (pub_release & gh_ibg_release) into one new job (release), that uses the latest fix from Instabug/Escape#58.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@TheBuggedYRN TheBuggedYRN changed the title Merge GH and Pub Release Jobs [MOB-9322] Merge GH and Pub Release Jobs Nov 2, 2022
@TheBuggedYRN TheBuggedYRN self-assigned this Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #282 (10f5ff6) into master (dfd7e52) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   81.84%   81.84%           
=======================================
  Files          17       17           
  Lines         369      369           
=======================================
  Hits          302      302           
  Misses         67       67           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TheBuggedYRN TheBuggedYRN force-pushed the ci/merge-publish-jobs branch 10 times, most recently from 7b17331 to 85d2744 Compare November 2, 2022 11:40
@TheBuggedYRN TheBuggedYRN force-pushed the ci/merge-publish-jobs branch 2 times, most recently from c89dacd to 10f5ff6 Compare November 2, 2022 11:56
@TheBuggedYRN TheBuggedYRN changed the title [MOB-9322] Merge GH and Pub Release Jobs [MOB-9322] Merge Release CI Jobs Together Nov 3, 2022
@ymabdallah ymabdallah merged commit 7266a75 into master Nov 3, 2022
@ymabdallah ymabdallah deleted the ci/merge-publish-jobs branch November 3, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants