Pub: dependency on https://host/dir/ installs into the wrong directory

[DartBot]

Originally opened as dart-lang/sdk#3493

This issue was originally filed by [email protected]

---

Paths ending in slash don't install properly - the git repo is checked out into packages/ instead of packages/foo/.
In particular, code.google.com recommends repo URLs ending in /.

I think it's detecting the repo name as the empty string, and so running 'git clone $repo packages/$reponame' does the wrong thing.

(Also, shouldn't it be naming the checkout dir after the dependency name in my pubspec? Those are guaranteed to be unique...)

e.g.

$ cat pubspec.yaml
dependencies:
  googleapis:
    git: https://code.google.com/p/foo/

$ pub install
Cloning into '/usr/local/google/home/sammccall/gits/dartapiarysamples/packages'...
Dependencies installed!

$ ls -a packages
. .. .git

[DartBot]

<img src="https://avatars.githubusercontent.com/u/2108507?v=3" align="left" width="48" height="48"hspace="10"> Comment by dgrove

---

cc @munificent.
Set owner to @nex3.
Added Area-Pub, Triaged labels.

[DartBot]

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent

---

Added this to the M1 milestone.

[DartBot]

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3

---

Fixed by dart-lang/sdk@4b76d74.

---

Added Fixed label.