-
Notifications
You must be signed in to change notification settings - Fork 231
Make asset consumption more explicit #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent Removed Pub-Build label. |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent Removed Priority-Unassigned label. |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent From our discussion yesterday, the current plan is that we'll add a method like: consumeInput(AssetId id) to Transform. Transformers can call that to explicitly prevent that asset from being forwarded. In addition, we'll change the default behavior so that a primary input is not automatically consumed. As far as we know, changing that default won't break any existing transformers because most of those output an asset on top of the primary input, which still effectively consumes it since it gets overwritten. |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent Issue dart-archive/barback#17 has been merged into this issue. |
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 Set owner to @nex3. |
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 Changed the title to: "Make asset consumption more explicit". |
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 After some discussion (see https://code.google.com/p/dart/issues/detail?id=14554#c5 for details), we've decided not to expose a general [consumeInput] function. Instead, we'll add a [consumePrimaryInput] function. |
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 dart-lang/sdk@d11e95b adds support for passing assets through a transformer by default. |
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 dart-lang/sdk@2c19a00 adds the ability for transformers to explicitly consume their primary inputs. Added Fixed label. |
<img src="https://avatars.githubusercontent.com/u/17034?v=3" align="left" width="96" height="96"hspace="10"> Issue by kevmoo
Originally opened as dart-lang/sdk#16612
Scenario: I have 10 pngs files in assets.
I'd like to generate a single png sprite, with a new file name, and not include the source images in output
The text was updated successfully, but these errors were encountered: