Skip to content

Make asset consumption more explicit #16612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevmoo opened this issue Feb 6, 2014 · 10 comments
Closed

Make asset consumption more explicit #16612

kevmoo opened this issue Feb 6, 2014 · 10 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug

Comments

@kevmoo
Copy link
Member

kevmoo commented Feb 6, 2014

Scenario: I have 10 pngs files in assets.

I'd like to generate a single png sprite, with a new file name, and not include the source images in output

@munificent
Copy link
Member

Removed Pub-Build label.
Added Pkg-Barback, Area-Pub labels.

@munificent
Copy link
Member

Removed Priority-Unassigned label.
Added Priority-Medium label.

@munificent
Copy link
Member

From our discussion yesterday, the current plan is that we'll add a method like:

   consumeInput(AssetId id)

to Transform. Transformers can call that to explicitly prevent that asset from being forwarded.

In addition, we'll change the default behavior so that a primary input is not automatically consumed. As far as we know, changing that default won't break any existing transformers because most of those output an asset on top of the primary input, which still effectively consumes it since it gets overwritten.

@munificent
Copy link
Member

Issue #14554 has been merged into this issue.

@nex3
Copy link
Member

nex3 commented Feb 14, 2014

Set owner to @nex3.
Added Started label.
Changed the title to: "Make asset forwarding more explicit".

@nex3
Copy link
Member

nex3 commented Feb 14, 2014

Changed the title to: "Make asset consumption more explicit".

@nex3
Copy link
Member

nex3 commented Feb 14, 2014

After some discussion (see https://code.google.com/p/dart/issues/detail?id=14554#c5 for details), we've decided not to expose a general [consumeInput] function. Instead, we'll add a [consumePrimaryInput] function.

@nex3
Copy link
Member

nex3 commented Feb 27, 2014

r33134 adds support for passing assets through a transformer by default.

@nex3
Copy link
Member

nex3 commented Mar 12, 2014

r33557 adds the ability for transformers to explicitly consume their primary inputs.


Added Fixed label.

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#847.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants