Skip to content

define variables in pub build for dart2js #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DartBot opened this issue Jun 5, 2015 · 2 comments
Closed

define variables in pub build for dart2js #848

DartBot opened this issue Jun 5, 2015 · 2 comments
Labels
closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="96" height="96"hspace="10"> Issue by sigmundch
Originally opened as dart-lang/sdk#16613


This should be a simple change, but it will be extremely useful.

What I'd like is to let codegenerators and runtime libraries to adapt their behavior based on the intended use of the code (distinguishing between dev time and deploy time and what kind of compilation strategy was used (debug/release))

We should be able to do so if we can pass 2 flags to dart2js automatically when calling pub build. I basically would like:

-Ddeployment=true
-Dmode=debug or release

Could we do that :)? pretty please?

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


Removed Type-Defect, Priority-Unassigned labels.
Added Type-Enhancement, Priority-High labels.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Added Duplicate label.
Marked as being merged into #829.

@DartBot DartBot added closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug Priority-High labels Jun 5, 2015
@DartBot DartBot closed this as completed Jun 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

1 participant