Skip to content

define variables in pub build for dart2js #16613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sigmundch opened this issue Feb 6, 2014 · 3 comments
Closed

define variables in pub build for dart2js #16613

sigmundch opened this issue Feb 6, 2014 · 3 comments
Labels
closed-duplicate Closed in favor of an existing report P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug

Comments

@sigmundch
Copy link
Member

This should be a simple change, but it will be extremely useful.

What I'd like is to let codegenerators and runtime libraries to adapt their behavior based on the intended use of the code (distinguishing between dev time and deploy time and what kind of compilation strategy was used (debug/release))

We should be able to do so if we can pass 2 flags to dart2js automatically when calling pub build. I basically would like:

-Ddeployment=true
-Dmode=debug or release

Could we do that :)? pretty please?

@sigmundch
Copy link
Member Author

Removed Type-Defect, Priority-Unassigned labels.
Added Type-Enhancement, Priority-High labels.

@nex3
Copy link
Member

nex3 commented Feb 7, 2014

Added Duplicate label.
Marked as being merged into #16370.

@sigmundch sigmundch added Type-Enhancement P1 A high priority bug; for example, a single project is unusable or has many test failures closed-duplicate Closed in favor of an existing report labels Feb 7, 2014
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#848.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants