Skip to content

Manipulate executable paths only as paths #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2018
Merged

Conversation

natebosch
Copy link
Member

Fixes #1878

@natebosch natebosch requested a review from nex3 April 24, 2018 22:29
Rename exectuableIds
@kevmoo
Copy link
Member

kevmoo commented Apr 24, 2018

...might consider adding appveyor to the mix for pub – help w/ this?

@natebosch natebosch merged commit c4dcaa2 into master Apr 24, 2018
@natebosch natebosch deleted the executables-as-paths branch April 24, 2018 23:14
@natebosch
Copy link
Member Author

There seem to be a lot of failing tests on windows outside of this.

I believe this would have been caught, but I don't think we'd get much value out of appveyor without a bunch of work to cleanup the existing tests.

@kevmoo
Copy link
Member

kevmoo commented Apr 24, 2018 via email

@nex3
Copy link
Member

nex3 commented Apr 25, 2018

Pub's tests passed on Windows for a long time. The fact that they aren't passing now is as likely to indicate Windows bugs as issues with the tests. It seems like time spent triaging them and ensuring that they all pass would be well-spent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants