Rename --checked to --check-asserts #1964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the old flag as an alias, run with checked mode if either is set. Behavior will be weird for cases like `--checked --no-check-asserts` but it's not worth the extra complexity to track that down. Update tests using the flag. Use consistent single quotes in the files that were being edited anyway.
|
Shouldn't we be going with |
|
See #1922 (comment) |
for consistency with the VM and Dart2Js
|
discussed offline. Went with |
jakemac53
approved these changes
Aug 8, 2018
chalin
reviewed
Aug 8, 2018
| argParser.addFlag("checked", | ||
| abbr: "c", help: "Enable runtime type checks and assertions."); | ||
| argParser.addOption("mode", help: "Deprecated option", hide: true); | ||
| argParser.addFlag('enable-asserts', help: 'Enable assert statements.'); |
There was a problem hiding this comment.
I took this directly from dart --help. If we want to change this I think we should do it in both places.
chalin
reviewed
Aug 8, 2018
| argParser.addFlag("checked", | ||
| abbr: "c", help: "Enable runtime type checks and assertions."); | ||
| argParser.addOption("mode", help: "Deprecated option", hide: true); | ||
| argParser.addFlag('enable-asserts', help: 'Enable assert statements.'); |
chalin
reviewed
Aug 8, 2018
| @@ -22,7 +22,7 @@ import 'utils.dart'; | |||
| /// | |||
| /// Arguments from [args] will be passed to the spawned Dart application. | |||
| /// | |||
| /// If [checked] is true, the program is run in checked mode. | |||
| /// If [checked] is true, the program is run with assertions enabled. | |||
There was a problem hiding this comment.
Here and elsewhere: how about "with assertion checking enabled"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the old flag as an alias, run with checked mode if either is set.
Behavior will be weird for cases like
--checked --no-check-assertsbutit's not worth the extra complexity to track that down.
Update tests using the flag.
Use consistent single quotes in the files that were being edited anyway.