Add support for global activating package from a custom pub URL #2041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
approved these changes
Feb 4, 2019
lib/src/command/global_activate.dart
Outdated
| @@ -38,6 +38,11 @@ class GlobalActivateCommand extends PubCommand { | |||
| argParser.addFlag("overwrite", | |||
| negatable: false, | |||
| help: "Overwrite executables from other packages with the same name."); | |||
|
|
|||
| argParser.addOption("source-url", | |||
There was a problem hiding this comment.
--server-url or --hosted-url might be better, the key for this in the pubspec is dependencies.<packageName>.hosted.url
Or maybe --hosted-source-url
natebosch
reviewed
Feb 6, 2019
lib/src/command/global_activate.dart
Outdated
| @@ -38,6 +38,11 @@ class GlobalActivateCommand extends PubCommand { | |||
| argParser.addFlag("overwrite", | |||
| negatable: false, | |||
| help: "Overwrite executables from other packages with the same name."); | |||
|
|
|||
| argParser.addOption("source-url", | |||
|
@natebosch @jonasfj Updated the command line option to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution for #2039, looking for feedback on whether or not this would be an acceptable addition.
The solution ended up being very straightforward since pub already knows how to handle dependencies from custom hosted pub servers and activating a package globally is essentially just performing a
pub getin a dummy package with a single dependency. All that was needed was a command-line flag to specify the custom pub URL that is then passed through to the.refFor()call used to build the dependency ref.I went with
--source-urlfor the CLI option mainly in an attempt to note its relation to--sourcewhile keeping it brief, but there may be a better name.Additionally, since this flag is only applicable when activating from a hosted source, it might be worth failing if it is used with a non-hosted source.