Don't precompile on pub get/upgrade by default #2277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
reviewed
Dec 10, 2019
lib/src/command/get.dart
Outdated
| help: "Precompile executables in immediate dependencies."); | ||
| defaultsTo: false, | ||
| help: "Precompile executables in immediate dependencies.\n" | ||
| "If false executables will be precompiled on first run."); |
There was a problem hiding this comment.
nit: Maybe something like:
If not given, executables will be precompiled by 'pub run'
We can also omit this completely.. But flags aren't really set false, they are more like given or not given.. or...
lib/src/command/upgrade.dart
Outdated
| help: "Precompile executables in immediate dependencies."); | ||
| defaultsTo: false, | ||
| help: "Precompile executables in immediate dependencies.\n" | ||
| "If false executables will be precompiled on first run."); |
jonasfj
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And only precompile the single desired executable on
pub run.Following the suggestion from the discussion on #1683 (comment) we avoid printing "precompiling executable..." on
pub runif we don't have a terminal attached. That allowspub runto be used in scripts without pollutingstdoutbut still explains the user where time is going on first run of eg.pub run test.This PR does not change
pub globalbehavior. We probably want to continue recompiling all executables onpub global activate.This PR still allows --precompile for those who prefer the old behavior.