Skip to content

Use LOCALAPPDATA for system cache on windows #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonasfj merged 4 commits into from
Jan 9, 2020
Merged

Use LOCALAPPDATA for system cache on windows #2297

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f872018
Use LOCALAPPDATA for system cache on windows
Jesse-Bakker Jan 7, 2020
9024daa
Formatting
Jesse-Bakker Jan 7, 2020
e0f918a
Use dirExists instead of Directory.existsSync for consistency
Jesse-Bakker Jan 8, 2020
f650df5
Explain why we fall back to %APPDATA% if it exists
Jesse-Bakker Jan 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/src/system_cache.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,14 @@ class SystemCache {
if (Platform.environment.containsKey('PUB_CACHE')) {
return Platform.environment['PUB_CACHE'];
} else if (Platform.isWindows) {
// If a cache dir already exists in %APPDATA%, use it, else default to %LOCALAPPDATA%

@jonasfj jonasfj Jan 8, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, Can we briefly explain that we prefer %APPDATA% if it already exists because older pub versions created the pub-cache here.
And maybe state that using %LOCALAPPDATA% is better because it's not synchronized.

var appData = Platform.environment['APPDATA'];
return p.join(appData, 'Pub', 'Cache');
var appDataCacheDir = p.join(appData, 'Pub', 'Cache');
if (Directory(appDataCacheDir).existsSync()) {

@jonasfj jonasfj Jan 8, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, but for consistency with the rest of the code base can we consider using dirExists(dir).

return appDataCacheDir;
}
var localAppData = Platform.environment['LOCALAPPDATA'];
return p.join(localAppData, 'Pub', 'Cache');
} else {
return '${Platform.environment['HOME']}/.pub-cache';
}
Expand Down