Include osx and windows testing on Travis #2299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Jan 9, 2020
jonasfj
approved these changes
Jan 13, 2020
This was referenced May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of tests that failed on windows, and also two real bug fixes:
pub global installnow printsprecompiling package:binaryinstead ofprecompiling package:bin\binaryon windows this is in:https://github.com/dart-lang/pub/pull/2299/files#diff-b1ce870c7577d3cee288f34e5e915f25L266
This is done by always using
/for relative paths in pubspec lock path-dependencies in https://github.com/dart-lang/pub/pull/2299/files#diff-8fe27ec90492ab7ba2ab8083a7e1db8eR141