Skip to content

Remove deprecation warning from pub top level. #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 9, 2020

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Nov 9, 2020

It caused breakage in dart test and flutter pub.

We considered testing for an environment variable that could be set up in the shell script starting pub in the sdk, but flutter invokes that same shell script.

@google-cla google-cla bot added the cla: yes label Nov 9, 2020
This reverts commit a159262.
@sigurdm sigurdm changed the title Remove deprecation Only print deprecation warning if environment variable is set Nov 9, 2020
@sigurdm sigurdm requested a review from jonasfj November 9, 2020 10:04
@sigurdm sigurdm changed the title Only print deprecation warning if environment variable is set Remove deprecation warning from pub top level. Nov 9, 2020
@sigurdm sigurdm merged commit 1686066 into dart-lang:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants