Analytics #2778
Analytics #2778
Conversation
lib/src/command.dart
Outdated
| @@ -110,6 +111,8 @@ abstract class PubCommand extends Command<int> { | |||
| return _pubEmbeddableCommand ?? (runner as PubCommandRunner); | |||
| } | |||
|
|
|||
| Analytics get analytics => _pubEmbeddableCommand?.analytics; | |||
There was a problem hiding this comment.
How about we make a _NullAnalytics and/or a _LoggingAnalytics implementation that just logs everything ping with log-level fine, I think that's useful for debugging, testing and whenever analytics is disabled.
lib/src/solver/result.dart
Outdated
| package.name, | ||
| label: package.version.toString(), | ||
| value: 1, | ||
| parameters: {'kind': dependencyType}, |
There was a problem hiding this comment.
Do we know what this looks like on google analytics?
I'm sure we can always do aggregations based on this using big query regardless, but it might be worth looking into.
There was a problem hiding this comment.
How about we make a _NullAnalytics and/or a _LoggingAnalytics implementation that just logs everything ping with log-level fine, I think that's useful for debugging, testing and whenever analytics is disabled.
I added fine logging to whenever we send analytics - this will be nice to have for user speculating what analytics are sent.
The embeeding_test has its own _LoggingAnalytics for testing.
Allow the embedder to provide an analytics instance, and send an analytics event about the resolution.