Skip to content

Downgrade actually modifies pubspec.lock #2859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2021
Merged

Downgrade actually modifies pubspec.lock #2859

merged 1 commit into from
Feb 1, 2021

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Feb 1, 2021

Downgrade was introduced here: https://codereview.chromium.org//365993007

And it seems there was always a call to saveLockfile().

Not saving the lockfile would also lead pub to complain when doing pub run.

@google-cla google-cla bot added the cla: yes label Feb 1, 2021
@sigurdm sigurdm requested a review from jonasfj February 1, 2021 13:47
@sigurdm sigurdm merged commit 16a6210 into master Feb 1, 2021
@jonasfj jonasfj deleted the fix_downgrade_doc branch February 1, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sigurdm @jonasfj