Skip to content

Don't allow outdated taking arguments #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2021

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Feb 5, 2021

Also fixes an issue where stack traces would be exposed to the user in case of some parsing errors (when using the pub binary - I don't think this happens with dart pub.
Fixes: #2868

@google-cla google-cla bot added the cla: yes label Feb 5, 2021
@sigurdm sigurdm requested a review from jonasfj February 5, 2021 09:24
Copy link
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@sigurdm sigurdm merged commit 73ad542 into dart-lang:master Feb 8, 2021
sigurdm added a commit that referenced this pull request Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dart pub outdated wrong_argument -- causes no issues
2 participants