Skip to content

Minor cleanup to reduce risk of using path.current #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

jonasfj
Copy link
Member

@jonasfj jonasfj commented Mar 18, 2021

This shouldn't have any side-effect, as nobody is calling without baseDir, this just stops people from using said footgun in the future.

@jonasfj jonasfj requested a review from sigurdm March 18, 2021 15:41
@google-cla google-cla bot added the cla: yes label Mar 18, 2021
@sigurdm sigurdm merged commit a03ac72 into dart-lang:master Mar 18, 2021
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants