Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third party hosted pub registry authentication #3007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Third party hosted pub registry authentication #3007
Changes from all commits
218d114
da1549f
becf34f
0999292
ac8b70f
fc12fa8
5a8d6f3
427a7d9
fd45e4a
7955153
719005d
383122d
15e6238
402154d
bf675a3
13f0fc0
8e7fd96
50a6b5f
84a6c95
8547a32
7896061
b2194de
6aeaec1
c917ec3
8d91007
d6e0254
094ad56
4f652ff
e937a37
f800eef
cac0fee
be1fee1
2ad3ebd
7286e4b
3e5a3e2
1308b4a
4eea298
4ee285a
5d57abb
1cc1bd8
dbedbaa
ec703f6
5b44966
f16fbbe
7dcfd97
d6399de
72973fc
99bccd8
951e5c3
42fcf2b
35d8896
030c6f9
946b547
e602167
0a37f19
73b921e
d431c08
d2f4115
f70e766
17400b0
38ca11c
ded22ce
19ec461
fc0af7e
92352ed
0bfc2d0
b34dacc
a27e89f
d4ca151
b8a779e
3ca7d0f
2e9105c
344cba6
e92b69e
98549b2
5ed7e03
bebc6d2
cab0343
82e5038
086053d
69f8f5b
7f3fa89
299a4f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this a format exception when loading. Then it'll get logged as a warning every time the user uses an old pub version with a newer config file.
Hmm, I can see that being less smart, but I also don't like dragging around nullability.
@sigurdm any thoughts here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is current saving mechanism will remove entries that doesn't contains 'token' property because it'll not be able to deserialize it. So they'll not added to the credential list and when saving those entries will be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to encapsulate json serialization part to
Credential
class itself to reduce code duplication for serialization & validation, otherwise the code would look like much confusing I think.