Use the frontend server to compile pub executables #3008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, I assumed this had been worked out because the test package does use it... but maybe it hasn't been updated either yet or something. I can look into it. |
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 20, 2021
unblocks dart-lang/pub#3008 Change-Id: I14ed70371001b0ca709469172afd2b97679a1e2b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200920 Auto-Submit: Jake Macdonald <[email protected]> Commit-Queue: Jonas Jensen <[email protected]> Reviewed-by: Jonas Jensen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3006 which reverted #2968, hence, introducing: Use the frontend server to compile pub executables.
cc @jakemac53
We can merge this once we've figured out how to use the
frontend_server_clientin the Dart SDK.