Skip to content

Add executables to allErrors #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

jonasfj
Copy link
Member

@jonasfj jonasfj commented Jul 19, 2021

Just discovered this while hacking something else, figure it might be worth fixing -- added some tests too, let's see if they pass.

@google-cla google-cla bot added the cla: yes label Jul 19, 2021
Copy link
Member

@athomas athomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasfj jonasfj merged commit 0f3055d into dart-lang:master Jul 22, 2021
@jonasfj jonasfj deleted the add-executables-to-allErrors branch July 22, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants