Skip to content

Fixed messages #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 86 commits into from
Sep 14, 2021
Merged

Fixed messages #3110

merged 86 commits into from
Sep 14, 2021

Conversation

themisir
Copy link
Contributor

Fixed invalid messages reported by @mnordine: this and that.

themisir and others added 30 commits May 19, 2021 03:09
@themisir
wip: Prepare authentication proposal
218d114
@themisir
doc: Add details about 'realm' parameter
da1549f
@themisir
Update authentication-proposal.md
becf34f 
- Modified references
- Added description about specs is based on RFC7235
@themisir
Merge branch 'dart-lang:master' into master
0999292
@themisir
Implement CredentialStore and Credential for bearer method
ac8b70f
@themisir
Login and logout commands with hosted pub repo
fc12fa8
@themisir
formatting: remove space
5a8d6f3
@themisir
Rename add/removeCredentials to add/removeServer
427a7d9
@themisir
Allow wrapping http clients
fd45e4a
@themisir
Implemented AuthenticationClient
7955153
@themisir
Authentication client added to stack of other clients
719005d
@themisir
Throw usage exception for more than one argument
383122d 
login and logout accepts only one argument at most.
@themisir
Implemented publishing with saved credential support
15e6238
@themisir
Modified authentication client
402154d
@themisir
Add comment documentation to AuthenticationClient
bf675a3
@themisir
Rename to/fromMap to to/fromJson
13f0fc0
@themisir
Login / logout now uses option parameter instead of argument
8e7fd96
@themisir
Authentication now needs to be used explicitly when needed
50a6b5f
@themisir
Update list command to use authenticated client
84a6c95
@themisir
Change access modifier for authenticationType to @Protected
8547a32
@themisir
Add docs
7896061
@themisir
Added file headers
b2194de
@themisir @jonasfj
Update lib/src/source/hosted.dart
6aeaec1 
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
@themisir
Rename server key to serverBaseUrl
c917ec3
@themisir
Removed alsoMatches argument
8d91007 
Because:

1. It's not needed anymore because authenticated client already checks request.url with serverBaseUrl
2. The value is wrong anyways (has to be url instead of archivePath)
@themisir
Rename _AuthenticationClient to _AuthenticatedClient
d6e0254
@themisir
Update credential Json serialization
094ad56
@themisir
Fixed credential server base url matching
4f652ff
@themisir
Rename some "key"s to "serverBaseUrl"
e937a37
@themisir
Updated proposal document
f800eef
themisir and others added 24 commits August 31, 2021 04:23
@themisir
Log token removal message in command body
ded22ce
@themisir
Remove duplicate tokens when adding a new one
19ec461
@themisir
Print information when 401 and 403 received
fc0af7e
@themisir
Break out of loop after finding first duplicate
92352ed
@themisir
Added or updated license headers
0bfc2d0
@themisir @sigurdm
Update lib/src/io.dart
b34dacc 
Co-authored-by: Sigurd Meldgaard <[email protected]>
@themisir
Change argument type of removeMatchingTokens from String to Uri
a27e89f
@themisir
Implement confirm using stdinPrompt
d4ca151
@themisir
Update messages for token commands
b8a779e
@themisir
Merge branch 'dart-lang:master' into master
3ca7d0f
@themisir
Remaining requested changes implemented
2e9105c 
- Modified messages
- Token renamed to Credential
@themisir
Merge branch 'master' of github.com:TheMisir/pub
344cba6
@themisir
Updated token tests according to recent changes
e92b69e
@themisir
Update helptext.txt golden
98549b2
@themisir
Do not expose oauth2 creds to 3rd party servers
5ed7e03
@themisir
Throw DataException when no token found for token remove
bebc6d2
@themisir
Merge branch 'dart-lang:master' into master
cab0343
@themisir
Persist unknown fields on unmodified token entries
82e5038
@themisir
Merge branch 'master' into master
086053d
@themisir
Allow mock servers to use oauth2 client
69f8f5b
@themisir
Truncate server message
7f3fa89
@themisir
Minor refactoring for Credential and TokenStore
299a4f3
@themisir
Merge branch 'dart-lang:master' into master
08d58eb
@themisir
Fixed messages
8981fe5
@themisir themisir marked this pull request as ready for review September 14, 2021 11:52
@google-cla google-cla bot added the cla: yes label Sep 14, 2021
@themisir themisir mentioned this pull request Sep 14, 2021
Merged
jonasfj
jonasfj approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, you'll probably want to update your master branch :D

@jonasfj jonasfj merged commit 4ee280b into dart-lang:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj jonasfj approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@themisir @jonasfj