Fix hanging event handler for stdin.
#3218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piping `stdin` to a `LineSplitter` and then using a `StreamQueue` causes event handler to wait for next characters after a line has been read. Hence, if we don't `exit()` explicitly or hit `stdin.close()` then the process will hang waiting for input on `stdin`. Using `stdin.readLineSync()` alleviates this issue. Having a timeout on prompts for tokens is nice, but only really required if we prompt while the solver is running. Which we probably won't need to do anyways, so not having a timeout is likely fine.
szakarias
approved these changes
Nov 9, 2021
jonasfj
added a commit
that referenced
this pull request
Nov 9, 2021
Piping `stdin` to a `LineSplitter` and then using a `StreamQueue` causes event handler to wait for next characters after a line has been read. Hence, if we don't `exit()` explicitly or hit `stdin.close()` then the process will hang waiting for input on `stdin`. Using `stdin.readLineSync()` alleviates this issue. Having a timeout on prompts for tokens is nice, but only really required if we prompt while the solver is running. Which we probably won't need to do anyways, so not having a timeout is likely fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piping
stdinto aLineSplitterand then using aStreamQueuecausesevent handler to wait for next characters after a line has been read.
Hence, if we don't
exit()explicitly or hitstdin.close()then theprocess will hang waiting for input on
stdin.Using
stdin.readLineSync()alleviates this issue. Having a timeout onprompts for tokens is nice, but only really required if we prompt while
the solver is running. Which we probably won't need to do anyways, so
not having a timeout is likely fine.
This should be cherry-picked for 2.15, I manually checked
tool/test-bin/pub_command_runner.dart pub token addandtool/test-bin/pub_command_runner.dart pub publishagainst master, and this seems to fix the issue.