Refactor the test package-server #3230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
reviewed
Nov 12, 2021
| builder.serve('foo', '3.2.1'); | ||
| builder.serve('bar', '1.0.0', deps: {'foo': '^3.2.1'}); | ||
| }); | ||
| final builder = await servePackages(); |
There was a problem hiding this comment.
Calling it builder is that a good name...
There was a problem hiding this comment.
No - just got tired of renaming - but let's shave the yak, I'll rename them all...
jonasfj
approved these changes
Nov 15, 2021
szakarias
reviewed
Nov 15, 2021
test/test_pub.dart
Outdated
| /// makes it the current [globalServer]. | ||
| /// | ||
| /// Calls [callback] with a [PackageServerBuilder] that's used to specify | ||
| /// which packages to serve. |
There was a problem hiding this comment.
Is this comment still up to date?
There was a problem hiding this comment.
Nope!
Thanks - fixed.
szakarias
reviewed
Nov 15, 2021
| }); | ||
| await servePackages() | ||
| ..serve('not_upgraded', '1.0.0') | ||
| ..serve('not_upgraded', '1.0.0') |
szakarias
reviewed
Nov 15, 2021
| }); | ||
| await servePackages() | ||
| ..serve('added', '1.0.0') | ||
| ..serve('added', '1.0.0') |
| }); | ||
| await servePackages() | ||
| ..serve('multiple_newer', '1.0.0') | ||
| ..serve('multiple_newer', '1.0.0') |
| ..serve('multiple_newer_unstable', '1.0.1-unstable.2') | ||
| ..serve('multiple_newer_unstable2', '1.0.1-unstable.1') | ||
| ..serve('multiple_newer_unstable2', '1.0.1-unstable.2') | ||
| ..serve('multiple_newer_unstable2', '1.0.1-unstable.2') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the action is in test/package_server.dart (and a bit in test/test_pub.dart).