Close the global http client after ensurePubspecResolved
#4199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
approved these changes
Mar 25, 2024
| @@ -52,6 +53,8 @@ Future<void> ensurePubspecResolved( | |||
| ); | |||
| } on ApplicationException catch (e) { | |||
| throw ResolutionFailedException._(e.toString()); | |||
| } finally { | |||
| globalHttpClient.close(); | |||
There was a problem hiding this comment.
Can we give it a documentation comment.
This is a bit of a hack, I don't mind. But ideally, we'd do something reasonable like creating an a client pass it in, and close it at the end. Or if we don't want to pass it around use zones or something.
There was a problem hiding this comment.
But ideally, we'd do something reasonable like creating an a client pass it in, and close it at the end.
Or if we don't want to pass it around use zones or something.
Yeah - that would be better...
I'll add a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart-lang/sdk#55289