Parallelize security advisories and package status fetching#4824
Merged
Conversation
…visories from network
sigurdm
commented
May 19, 2026
| cachedAdvisoriesUpdated, | ||
| ); | ||
| final advisoriesUpdated = | ||
| (await status(id.toRef(), id.version, cache)).advisoriesUpdated; |
Contributor
Author
There was a problem hiding this comment.
Here we were missing the maxAge
… status cache bypass
jonasfj
approved these changes
May 22, 2026
jonasfj
reviewed
May 22, 2026
| futures.add(advisoriesFuture); | ||
| } | ||
| } | ||
| await Future.wait(futures); |
Member
There was a problem hiding this comment.
Do we have concurrency limits here? probably that exists in fetch and schedule logic, just wanted to check.
Contributor
Author
There was a problem hiding this comment.
Really good point. Shared the pool with the ratelimitedscheduler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4818
Also fix a bug where we were not passing a maxAge to gate the advisory cache age.
Also adds a 24-hour buffer to the file-timestamp comparison we do to fast-check if the cached advisories is out of date. (We compare against the written timestamp afterwards).