solver: suggest workspace resolution fixes#4838
Open
aikins01 wants to merge 2 commits into
Open
Conversation
Enable solve suggestions for workspace dependency conflicts by locating the owning workspace pubspec and generating directory-aware pub add commands. Preserve hosted source descriptions for workspace member suggestions, suppress invalid non-hosted root descriptors, and keep the major-versions fallback directory-aware.
Contributor
|
As I understand this PR, it will still only attempt to relax constraints for each dependency in a single workspace member at a time. I think we need to test for relaxing the constraint across the workspace in one go. Not sure how to best express that as a command. Can we use the new |
Contributor
Author
|
Thanks, added a workspace-wide case that suggests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables version solving suggestions for workspace dependency conflicts.
This locates the owning workspace pubspec for direct hosted constraints, emits directory-aware pub add and major-upgrade commands, preserves hosted sources for workspace member suggestions, and suppresses invalid path/git root descriptors.
Fixes #4227.
Related to #4127.