[tools/deps] Adjust commit messages to link to correct repositories

Prevents auto-linking to incorrect issue when the tool's output is committed. Do this by removing the hash from `#number` in the commit message, and replacing the PR link at the of the message with a fully qualified reference that resolves to the correct repository on GitHub.

An example of the new output:

```
yaml (https://github.com/dart-lang/yaml/compare/98a3aab..509fd72):
  509fd72  Mon Dec 11 16:37:13 2023 -0800  Kevin Moore  update lints, require Dart 3.0 (dart-archive/yaml#156)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/9b9d33c..47eb20e):
  47eb20e  Mon Jan 1 13:13:22 2024 +0000  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (dart-archive/yaml_edit#63)
  a39ec39  Wed Dec 20 11:51:28 2023 -0800  Kevin Moore  blast_repo fixes (dart-archive/yaml_edit#62)
```

Closes #53857

Change-Id: I23e9d556c69445189a916ce33091a9c77ae15941
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/344361
Commit-Queue: Nate Bosch <[email protected]>
Reviewed-by: Nate Bosch <[email protected]>
Auto-Submit: Parker Lougheed <[email protected]>
Reviewed-by: Devon Carew <[email protected]>

Author: parlough

tools/rev_sdk_deps.dart

@@ -88,20 +88,31 @@ void main(List<String> args) async {
   print('Revisions updated by `dart tools/rev_sdk_deps.dart`.');
   print('');
 
-  for (var entry in revDepsToCommits.entries) {
-    final dep = entry.key;
-    final commit = entry.value;
-
+  for (final MapEntry(key: dep, value: commit) in revDepsToCommits.entries) {
     final git = GitHelper(dep.relativePath);
 
-    var gitLog = await git.calculateUnsyncedCommits();
-    var currentHash = await gclient.getHash(dep);
+    final gitLog = await git.calculateUnsyncedCommits();
+    final currentHash = await gclient.getHash(dep);
+
+    final gitHubRepo = dep.gitHubRepoIdentifier;
+
+    // Construct and print out the GitHub diff URL.
+    print('${dep.name} (${dep.gitHubDiffUrl(currentHash, commit)}):');
 
-    // Construct the github diff URL.
-    print('${dep.name} (${dep.getGithubDiffUrl(currentHash, commit)}):');
+    /// Qualify or wrap the GitHub issue references within [commitMessage].
+    String replaceHashReferences(String commitMessage) => commitMessage
+        .replaceAllMapped(
+          _mergeCommitPullRequestReference,
+          (m) => '($gitHubRepo#${m[1]})',
+        )
+        .replaceAllMapped(_issueHashReference, (m) => '`${m[0]}`');
 
-    // Print out the new commits.
-    print(gitLog.split('\n').map((l) => '  $l').join('\n').trimRight());
+    // Format and print out the message header of each new commit.
+    final newCommitHeaders = [
+      for (final commitHeader in gitLog.split('\n'))
+        '  ${replaceHashReferences(commitHeader)}',
+    ];
+    print(newCommitHeaders.join('\n').trimRight());
 
     // Update the DEPS file.
     await gclient.setHash(dep, commit);
@@ -123,6 +134,20 @@ void main(List<String> args) async {
   }
 }
 
+/// A regex that matches the final PR reference of a merge commit header.
+///
+/// Allows replacing the PR reference with a repository qualified reference,
+/// so that GitHub auto links to the correct repository instead of
+/// an irrelevant issue or PR on the SDK repository.
+final RegExp _mergeCommitPullRequestReference = RegExp(r'\(#?(\d+)\)$');
+
+/// A regex that matches any non-qualified issue or PR references
+/// within a commit message, such as `#123`.
+///
+/// Allows replacing or wrapping the potential issue or PR references so that
+/// GitHub doesn't autolink to an irrelevant issue or PR on the SDK repository.
+final RegExp _issueHashReference = RegExp(r'\B#\d+');
+
 // By convention, pinned deps are deps with an eol comment.
 Set<String> calculatePinnedDeps() {
   final packageRevision = RegExp(r'"(\w+)_rev":');
@@ -266,24 +291,34 @@ class PackageDependency {
 
   String get relativePath => entry.substring('sdk/'.length);
 
-  String getGithubDiffUrl(String fromCommit, String toCommit) {
-    // https://github.com/dart-lang/<repo>/compare/<old>..<new>
-    final from = fromCommit.substring(0, 7);
-    final to = toCommit.substring(0, 7);
-
+  /// The identifier of the GitHub repository this dependency is from.
+  ///
+  /// For example: `dart-lang/test`.
+  String get gitHubRepoIdentifier {
     var repo = url.substring(url.lastIndexOf('/') + 1);
     if (repo.endsWith('git')) {
       repo = repo.substring(0, repo.length - '.git'.length);
     }
 
-    var org = 'dart-lang';
+    final String org;
     if (url.contains('/external/')) {
       // https://dart.googlesource.com/external/github.com/google/webdriver.dart.git
       final parts = url.split('/');
       org = parts[parts.length - 2];
+    } else {
+      org = 'dart-lang';
     }
 
-    return 'https://github.com/$org/$repo/compare/$from..$to';
+    return '$org/$repo';
+  }
+
+  /// The URL of the GitHub comparison view between [fromCommit] and [toCommit].
+  Uri gitHubDiffUrl(String fromCommit, String toCommit) {
+    // https://github.com/dart-lang/<repo>/compare/<old>..<new>
+    final from = fromCommit.substring(0, 7);
+    final to = toCommit.substring(0, 7);
+
+    return Uri.https('github.com', '$gitHubRepoIdentifier/compare/$from..$to');
   }
 
   @override