Don't report VALUES_DECLARATION_IN_ENUM for static setter.

See dart-lang/co19#1312

Change-Id: Ie535a826a2997c45344486febbb8cc35a748496c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236300
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/error/listener.dart

@@ -70,8 +70,9 @@ class ErrorReporter {
   /// is used to compute the location of the error.
   void reportErrorForElement(ErrorCode errorCode, Element element,
       [List<Object>? arguments]) {
-    reportErrorForOffset(errorCode, element.nonSynthetic.nameOffset,
-        element.nameLength, arguments);
+    var nonSynthetic = element.nonSynthetic;
+    reportErrorForOffset(
+        errorCode, nonSynthetic.nameOffset, nonSynthetic.nameLength, arguments);
   }
 
   /// Report a diagnostic with the given [code] and [arguments]. The

pkg/analyzer/lib/src/error/duplicate_definition_verifier.dart

@@ -93,7 +93,9 @@ class DuplicateDefinitionVerifier {
           member.name,
           setterScope: member.isStatic ? staticSetters : instanceSetters,
         );
-        _checkValuesDeclarationInEnum(member.name);
+        if (!(member.isStatic && member.isSetter)) {
+          _checkValuesDeclarationInEnum(member.name);
+        }
       }
     }
 

pkg/analyzer/test/src/diagnostics/getter_not_subtype_setter_types_test.dart

@@ -326,6 +326,17 @@ enum E {
     ]);
   }
 
+  test_enum_static_generatedGetter_thisSetter_index() async {
+    await assertErrorsInCode('''
+enum E {
+  v;
+  static set values(int _) {}
+}
+''', [
+      error(CompileTimeErrorCode.GETTER_NOT_SUBTYPE_SETTER_TYPES, 5, 1),
+    ]);
+  }
+
   test_extension_instance() async {
     await assertErrorsInCode('''
 extension E on Object {

pkg/analyzer/test/src/diagnostics/values_declaration_in_enum_test.dart

@@ -115,13 +115,11 @@ enum E {
   }
 
   test_setter_static() async {
-    await assertErrorsInCode(r'''
+    await assertNoErrorsInCode(r'''
 enum E {
   v;
   static set values(_) {}
 }
-''', [
-      error(CompileTimeErrorCode.VALUES_DECLARATION_IN_ENUM, 27, 6),
-    ]);
+''');
   }
 }