Correct an enhanced-enum test to allow setters named values #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
approved these changes
Mar 9, 2022
scheglov
approved these changes
Mar 9, 2022
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Mar 9, 2022
See dart-lang/co19#1312 Change-Id: Ie535a826a2997c45344486febbb8cc35a748496c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236300 Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Mar 17, 2022
2022-03-16 [email protected] Fixes needed based on roll f5124538 (dart-lang/co19#1323) 2022-03-14 [email protected] Fixes dart-lang/co19#1310. Add language version 2.16 (dart-lang/co19#1314) 2022-03-10 [email protected] Correct an enhanced-enum test to alow setters named values (dart-lang/co19#1312) 2022-02-25 [email protected] dart-lang/co19#993. Added tests for Abi class 2022-02-25 [email protected] dart-lang/co19#1258. Added test for a generic enum which does have a regular-bounded instantiate-to-bounds result 2022-02-24 [email protected] Fixes dart-lang/co19#1308. Make `UriData` tests case-insensitive 2022-02-24 [email protected] dart-lang/co19#1258. Not regular-bounded enum test added 2022-02-21 [email protected] Merge remote-tracking branch 'remotes/origin/weak-reference-fix' 2022-02-21 [email protected] Revert accidental commits 2022-02-21 [email protected] dart-lang/co19#1305. Some cascaded errors previously reported by CFE removed 2022-02-21 [email protected] dart-lang/co19#1258. Added tests for overridden == operator 2022-02-21 [email protected] dart-lang/co19#1260. Added test for callback that throws an exception 2022-02-21 [email protected] Fixes dart-lang/co19#1307. Remove overridden == operator from enum 2022-02-21 [email protected] dart-lang/co19#1305. Some cascaded errors previously reported by CFE removed 2022-02-21 [email protected] dart-lang/co19#1260. Added test for callback that throws an exception 2022-02-21 [email protected] dart-lang/co19#1258. Added tests for overridden == operator 2022-02-20 [email protected] Fixes dart-lang/co19#1307. Remove overridden == operator from enum 2022-02-19 [email protected] dart-lang/co19#1260. Fixed tests that check attachment of the same object to finalizer several times 2022-02-18 [email protected] dart-lang/co19#1260: Weak reference tests updated. 2022-02-18 [email protected] dart-lang/co19#1258. More implementing enums tests added 2022-02-17 [email protected] Fixes dart-lang/sdkdart-lang/co19#48412. Different issues fixed in Finalizer tests 2022-02-17 [email protected] dart-lang/co19#1260. Finalizer test improved 2022-02-17 [email protected] dart-lang/co19#1260. Minor code enhancement 2022-02-16 [email protected] dart-lang/co19#1260. Typo fixed 2022-02-16 [email protected] dart-lang/co19#1260. Fix attach to finalizer tests 2022-02-16 [email protected] dart-lang/co19#1260. Finalizer tests fixed and refactored 2022-02-16 [email protected] dart-lang/co19#1260. Another WeakReference tests added 2022-02-15 [email protected] dart-lang/co19#1260: Finalizer tests updated. 2022-02-15 [email protected] Fixes dart-lang/sdkdart-lang/co19#48391. Use function with 'no-inline' to create a WeakReference and to lost link to its target 2022-02-15 [email protected] dart-lang/co19#1260: Finalizer tests updated. 2022-02-14 [email protected] dart-lang/co19#130. Roll failure fixed Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-mac-release-simarm64-try,vm-kernel-precomp-nnbd-win-release-x64-try Change-Id: Icc2bea05df29e00b671b2843af7c3c55fa45da35 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237581 Reviewed-by: William Hesse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a discussion with Erik about the static
valuessetter in enums, and the conclusion is that they should be allowed. This PR adjusts a test accordingly.