Skip to content

Commit 5479175

Browse files
mralephcommit-bot@chromium.org
authored andcommitted
Remove incorrect test.
Symbol constructor can't be used to create symbols for private names. Closes #34377 Closes #30848 #36433 #34904 Change-Id: Ibe551c43a9209e1f483cea8178665890d52799aa Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108416 Reviewed-by: Vyacheslav Egorov <[email protected]> Commit-Queue: Vyacheslav Egorov <[email protected]>
1 parent 058092b commit 5479175

File tree

5 files changed

+0
-50
lines changed

5 files changed

+0
-50
lines changed

tests/language_2/language_2_analyzer.status

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ malformed2_test: Pass, MissingCompileTimeError # Flaky: issue 31056.
7171
mixin_method_override_test/01: MissingCompileTimeError
7272
mixin_super_2_test: CompileTimeError
7373
mixin_super_use_test: CompileTimeError
74-
mock_writable_final_private_field_test: CompileTimeError # failing-by-design, see Issue #34377
7574
nested_generic_closure_test: CompileTimeError # Issue #28515
7675
no_main_test/01: Fail # failing-by-design, the analyzer has no restriction that a library include a main function.
7776
no_such_constructor2_test: StaticWarning

tests/language_2/language_2_dart2js.status

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,6 @@ mixin_illegal_superclass_test/29: MissingCompileTimeError
160160
mixin_illegal_superclass_test/30: MissingCompileTimeError
161161
mixin_method_override_test/G5: Skip # Issue 34354
162162
mock_writable_final_field_test: RuntimeError # Issue 30847
163-
mock_writable_final_private_field_test: RuntimeError # Issue 17526, 30847
164163
modulo_test: RuntimeError # non JS number semantics
165164
named_parameters_default_eq_test/none: RuntimeError
166165
nan_identical_test: RuntimeError # Issue 11551
@@ -455,7 +454,6 @@ mixin_mixin_bound_test: RuntimeError
455454
mixin_mixin_test: RuntimeError
456455
mixin_type_parameters_super_test: RuntimeError
457456
mock_writable_final_field_test: RuntimeError # Issue 30847
458-
mock_writable_final_private_field_test: RuntimeError # Issue 17526, 30847
459457
modulo_test: RuntimeError # non JS number semantics
460458
nan_identical_test: RuntimeError # Issue 11551
461459
no_main_test/01: CompileTimeError

tests/language_2/language_2_dartdevc.status

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ mixin_declaration/mixin_declaration_factory_test/02: Crash
104104
mixin_method_override_test/01: MissingCompileTimeError
105105
mixin_super_2_test: CompileTimeError # Issue 34806
106106
mixin_super_use_test: CompileTimeError # Issue 34806
107-
mock_writable_final_private_field_test: CompileTimeError # Issue 30848
108107
nested_generic_closure_test: CompileTimeError
109108
nnbd/*: Skip
110109
override_inheritance_field_test/42: CompileTimeError
@@ -245,7 +244,6 @@ mixin_illegal_superclass_test/29: MissingCompileTimeError
245244
mixin_illegal_superclass_test/30: MissingCompileTimeError
246245
mixin_super_2_test: RuntimeError # Issue 34807
247246
mixin_super_use_test: RuntimeError # Issue 34808
248-
mock_writable_final_private_field_test: RuntimeError
249247
multiline_newline_test/04: MissingCompileTimeError
250248
multiline_newline_test/04r: MissingCompileTimeError
251249
multiline_newline_test/05: MissingCompileTimeError

tests/language_2/language_2_kernel.status

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1046,7 +1046,6 @@ redirecting_factory_reflection_test: RuntimeError
10461046
generic_function_bounds_test: RuntimeError # Issue 32076
10471047

10481048
[ $compiler == dartkb || $compiler == dartkp ]
1049-
mock_writable_final_private_field_test: CompileTimeError # Test uses Symbol("_...") which is a compile-time error.
10501049
set_literals/invalid_set_literal_test/29: Pass # Gen_kernel does does constant
10511050
set_literals/invalid_set_literal_test/30: Pass # evalutation, so these tests
10521051
set_literals/invalid_set_literal_test/31: Pass # throw the expected errors. The

tests/language_2/mock_writable_final_private_field_test.dart

Lines changed: 0 additions & 44 deletions
This file was deleted.

0 commit comments

Comments
 (0)