Revert "[analysis_server] Use fixDataYamlFolder constant instead of string literals"

This reverts commit ccb02fa.

Reason for revert: Blocking revert in https://dart-review.googlesource.com/c/sdk/+/297320

Original change's description:
> [analysis_server] Use fixDataYamlFolder constant instead of string literals
>
> Follow-up from https://dart-review.googlesource.com/c/sdk/+/296801.
>
> Change-Id: I72ea8a42ec64c4bd6c6cee021a1464167ec368e6
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296862
> Reviewed-by: Brian Wilkerson <[email protected]>
> Commit-Queue: Brian Wilkerson <[email protected]>

Change-Id: I8ed39fc343b9121c40de83038e97c43cac669ca1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/297321
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Zach Anderson <[email protected]>

Author: zanderso

pkg/analysis_server/lib/src/context_manager.dart

@@ -458,7 +458,7 @@ class ContextManagerImpl implements ContextManager {
         // packageName/lib/fix_data.yaml
         packageName = pathSegments[pathSegments.length - 3];
       } else {
-        var fixDataIndex = pathSegments.indexOf(file_paths.fixDataYamlFolder);
+        var fixDataIndex = pathSegments.indexOf('fix_data');
         if (fixDataIndex >= 2) {
           // packageName/lib/fix_data/foo/bar/fix.yaml
           packageName = pathSegments[fixDataIndex - 2];
@@ -574,7 +574,7 @@ class ContextManagerImpl implements ContextManager {
 
           var fixDataFolder = rootFolder
               .getChildAssumingFolder('lib')
-              .getChildAssumingFolder(file_paths.fixDataYamlFolder);
+              .getChildAssumingFolder('fix_data');
           if (fixDataFolder.exists) {
             _analyzeFixDataFolder(driver, fixDataFolder, packageName);
           }

pkg/analyzer/lib/src/util/file_paths.dart

@@ -72,7 +72,7 @@ bool isDart(p.Context pathContext, String path) {
 /// Such files specify data-driven fixes.
 bool isFixDataYaml(p.Context pathContext, String path) {
   return pathContext.basename(path) == fixDataYaml ||
-      (pathContext.split(path).contains(fixDataYamlFolder) &&
+      (pathContext.split(path).contains('fix_data') &&
           pathContext.extension(path) == '.yaml');
 }