Skip to content

Commit c84c1cb

Browse files
committed
[benchmark] Don't pass --sound-null-safety to dart_precompiled_runtime2.
The autodetection was fixed in bbc8aed, so the workaround of passing --sound-null-safety to the AOT runtime is no longer needed. This change tests that the autodetection does in fact work. Bug: #42421 Change-Id: Ibbe9665905e817a28964b698e6c437897c9dc6ee Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153771 Reviewed-by: Alexander Markov <[email protected]>
1 parent 9a4e2b1 commit c84c1cb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/bots/try_benchmarks.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ EOF
326326
DART_CONFIGURATION=ReleaseX64 pkg/vm/tool/precompiler2 --packages=.packages hello.dart blob.bin
327327
DART_CONFIGURATION=ReleaseX64 pkg/vm/tool/dart_precompiled_runtime2 --profile-period=10000 blob.bin
328328
DART_CONFIGURATION=ReleaseX64 pkg/vm/tool/precompiler2 --sound-null-safety --enable-experiment=non-nullable --packages=.packages hello.dart blob.bin
329-
DART_CONFIGURATION=ReleaseX64 pkg/vm/tool/dart_precompiled_runtime2 --sound-null-safety --profile-period=10000 blob.bin
329+
DART_CONFIGURATION=ReleaseX64 pkg/vm/tool/dart_precompiled_runtime2 --profile-period=10000 blob.bin
330330
out/ReleaseX64/dart --profile-period=10000 --packages=.packages --optimization-counter-threshold=-1 hello.dart
331331
out/ReleaseX64/dart-sdk/bin/dart2js --packages=.packages --out=out.js -m hello.dart
332332
third_party/d8/linux/x64/d8 --stack_size=1024 sdk/lib/_internal/js_runtime/lib/preambles/d8.js out.js

0 commit comments

Comments
 (0)