Skip to content

[VM] Auto-detection of null-safety mode doesn't work for AOT snapshots #42421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexmarkov opened this issue Jun 19, 2020 · 1 comment
Closed

[VM] Auto-detection of null-safety mode doesn't work for AOT snapshots #42421

alexmarkov opened this issue Jun 19, 2020 · 1 comment
Assignees
@a-siva
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release

Comments

@alexmarkov
Copy link
Contributor 

$ pkg/vm/tool/precompiler2 --enable-experiment=non-nullable --null-safety foo.dart foo.snapshot

$ pkg/vm/tool/dart_precompiled_runtime2 foo.snapshot
VM initialization failed: Snapshot not compatible with the current VM configuration: the snapshot requires 'release no-dwarf_stack_traces_mode causal_async_stacks no-lazy_async_stacks use_bare_instructions no-dedup_instructions no-"asserts" no-code-comments x64-sysv null-safety' but the VM has 'release no-dwarf_stack_traces_mode causal_async_stacks no-lazy_async_stacks use_bare_instructions no-dedup_instructions no-"asserts" no-code-comments x64-sysv no-null-safety'

$ pkg/vm/tool/dart_precompiled_runtime2 --null-safety foo.snapshot
Hello, Dart!

/cc @a-siva
@alexmarkov alexmarkov added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release labels Jun 19, 2020
@a-siva a-siva self-assigned this Jun 19, 2020
@a-siva
Copy link
Contributor

a-siva commented Jun 20, 2020

https://dart-review.googlesource.com/c/sdk/+/151866

@a-siva a-siva closed this as completed Jun 20, 2020
dart-bot pushed a commit that referenced this issue Jun 20, 2020
@a-siva
[VM/Runtime] - Fix for issue #42421
bbc8aed 
Set global null safety flag based on the snapshot instead of trying to
detect it per isolate (was causing issues with the vm isolate loading).
Should fix #42421

Bug:42421
Change-Id: I9143560b76fedcb991e96522cbf5d820fde99f7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151866
Reviewed-by: Alexander Markov <[email protected]>
Commit-Queue: Siva Annamalai <[email protected]>
skia-flutter-autoroll added a commit to skia-flutter-autoroll/engine that referenced this issue Jun 20, 2020
@skia-flutter-autoroll
Roll Dart SDK from 9fcac03 to bbc8aed (9 revisions)
7220e78 
https://dart.googlesource.com/sdk.git/+log/9fcac032b669..bbc8aedada6f

2020-06-20 [email protected] [VM/Runtime] - Fix for issue dart-lang/sdk#42421
2020-06-20 [email protected] Added module information to metadata and use by frontend_sever
2020-06-19 [email protected] [ddc] Normalize T to Never when T extends Never
2020-06-19 [email protected] [dart:io] HttpClientConnection is destroyed for "CONNECT" request
2020-06-19 [email protected] [dart2js] Add support for Never as a type literal.
2020-06-19 [email protected] [dart2js] Visit type parameter bounds in the scope visitor.
2020-06-19 [email protected] Migrate language_2/type_promotion to NNBD.
2020-06-19 [email protected] Add CiderCompletionComputer.warmUp()
2020-06-19 [email protected] Fix duration.toString() to conform the description

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
This was referenced Jun 20, 2020
Closed
Closed
skia-flutter-autoroll added a commit to skia-flutter-autoroll/engine that referenced this issue Jun 20, 2020
@skia-flutter-autoroll
Roll Dart SDK from 9fcac03 to 5316f32 (12 revisions)
d6b3d3e 
https://dart.googlesource.com/sdk.git/+log/9fcac032b669..5316f32a6468

2020-06-20 [email protected] [benchmark] BigIntParsePrint: Hoist value in all loops
2020-06-20 [email protected] Reland : [VM/Runtime] Cleanup package config initialization code
2020-06-20 [email protected] [dart2js] final locals may be assigned
2020-06-20 [email protected] [VM/Runtime] - Fix for issue dart-lang/sdk#42421
2020-06-20 [email protected] Added module information to metadata and use by frontend_sever
2020-06-19 [email protected] [ddc] Normalize T to Never when T extends Never
2020-06-19 [email protected] [dart:io] HttpClientConnection is destroyed for "CONNECT" request
2020-06-19 [email protected] [dart2js] Add support for Never as a type literal.
2020-06-19 [email protected] [dart2js] Visit type parameter bounds in the scope visitor.
2020-06-19 [email protected] Migrate language_2/type_promotion to NNBD.
2020-06-19 [email protected] Add CiderCompletionComputer.warmUp()
2020-06-19 [email protected] Fix duration.toString() to conform the description

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Closed
skia-flutter-autoroll added a commit to skia-flutter-autoroll/engine that referenced this issue Jun 20, 2020
@skia-flutter-autoroll
Roll Dart SDK from 9fcac03 to 7517a09 (14 revisions)
f2775aa 
https://dart.googlesource.com/sdk.git/+log/9fcac032b669..7517a0903bc3

2020-06-20 [email protected] [cfe] Mark late setters as isGenericCovariantImpl
2020-06-20 [email protected] Add --track-widget-creation to kernel_front_end.dart
2020-06-20 [email protected] [benchmark] BigIntParsePrint: Hoist value in all loops
2020-06-20 [email protected] Reland : [VM/Runtime] Cleanup package config initialization code
2020-06-20 [email protected] [dart2js] final locals may be assigned
2020-06-20 [email protected] [VM/Runtime] - Fix for issue dart-lang/sdk#42421
2020-06-20 [email protected] Added module information to metadata and use by frontend_sever
2020-06-19 [email protected] [ddc] Normalize T to Never when T extends Never
2020-06-19 [email protected] [dart:io] HttpClientConnection is destroyed for "CONNECT" request
2020-06-19 [email protected] [dart2js] Add support for Never as a type literal.
2020-06-19 [email protected] [dart2js] Visit type parameter bounds in the scope visitor.
2020-06-19 [email protected] Migrate language_2/type_promotion to NNBD.
2020-06-19 [email protected] Add CiderCompletionComputer.warmUp()
2020-06-19 [email protected] Fix duration.toString() to conform the description

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
skia-flutter-autoroll added a commit to skia-flutter-autoroll/engine that referenced this issue Jun 20, 2020
@skia-flutter-autoroll
Roll Dart SDK from 9fcac03 to d46a696 (15 revisions)
f62ffb4 
https://dart.googlesource.com/sdk.git/+log/9fcac032b669..d46a69695788

2020-06-20 [email protected] Revert "Reland : [VM/Runtime] Cleanup package config initialization code"
2020-06-20 [email protected] [cfe] Mark late setters as isGenericCovariantImpl
2020-06-20 [email protected] Add --track-widget-creation to kernel_front_end.dart
2020-06-20 [email protected] [benchmark] BigIntParsePrint: Hoist value in all loops
2020-06-20 [email protected] Reland : [VM/Runtime] Cleanup package config initialization code
2020-06-20 [email protected] [dart2js] final locals may be assigned
2020-06-20 [email protected] [VM/Runtime] - Fix for issue dart-lang/sdk#42421
2020-06-20 [email protected] Added module information to metadata and use by frontend_sever
2020-06-19 [email protected] [ddc] Normalize T to Never when T extends Never
2020-06-19 [email protected] [dart:io] HttpClientConnection is destroyed for "CONNECT" request
2020-06-19 [email protected] [dart2js] Add support for Never as a type literal.
2020-06-19 [email protected] [dart2js] Visit type parameter bounds in the scope visitor.
2020-06-19 [email protected] Migrate language_2/type_promotion to NNBD.
2020-06-19 [email protected] Add CiderCompletionComputer.warmUp()
2020-06-19 [email protected] Fix duration.toString() to conform the description

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
This was referenced Jun 20, 2020
Closed
Closed
skia-flutter-autoroll added a commit to skia-flutter-autoroll/engine that referenced this issue Jun 20, 2020
@skia-flutter-autoroll
Roll Dart SDK from 9fcac03 to 7621137 (16 revisions)
c6a0053 
https://dart.googlesource.com/sdk.git/+log/9fcac032b669..762113758de6

2020-06-20 [email protected] Enable v1.9 pedantic lints...
2020-06-20 [email protected] Revert "Reland : [VM/Runtime] Cleanup package config initialization code"
2020-06-20 [email protected] [cfe] Mark late setters as isGenericCovariantImpl
2020-06-20 [email protected] Add --track-widget-creation to kernel_front_end.dart
2020-06-20 [email protected] [benchmark] BigIntParsePrint: Hoist value in all loops
2020-06-20 [email protected] Reland : [VM/Runtime] Cleanup package config initialization code
2020-06-20 [email protected] [dart2js] final locals may be assigned
2020-06-20 [email protected] [VM/Runtime] - Fix for issue dart-lang/sdk#42421
2020-06-20 [email protected] Added module information to metadata and use by frontend_sever
2020-06-19 [email protected] [ddc] Normalize T to Never when T extends Never
2020-06-19 [email protected] [dart:io] HttpClientConnection is destroyed for "CONNECT" request
2020-06-19 [email protected] [dart2js] Add support for Never as a type literal.
2020-06-19 [email protected] [dart2js] Visit type parameter bounds in the scope visitor.
2020-06-19 [email protected] Migrate language_2/type_promotion to NNBD.
2020-06-19 [email protected] Add CiderCompletionComputer.warmUp()
2020-06-19 [email protected] Fix duration.toString() to conform the description

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
skia-flutter-autoroll added a commit to skia-flutter-autoroll/engine that referenced this issue Jun 21, 2020
@skia-flutter-autoroll
Roll Dart SDK from 9fcac03 to 52dd486 (17 revisions)
94339d3 
https://dart.googlesource.com/sdk.git/+log/9fcac032b669..52dd48651be4

2020-06-21 [email protected] Convert the remaining quick assists to use CorrectionProducer
2020-06-20 [email protected] Enable v1.9 pedantic lints...
2020-06-20 [email protected] Revert "Reland : [VM/Runtime] Cleanup package config initialization code"
2020-06-20 [email protected] [cfe] Mark late setters as isGenericCovariantImpl
2020-06-20 [email protected] Add --track-widget-creation to kernel_front_end.dart
2020-06-20 [email protected] [benchmark] BigIntParsePrint: Hoist value in all loops
2020-06-20 [email protected] Reland : [VM/Runtime] Cleanup package config initialization code
2020-06-20 [email protected] [dart2js] final locals may be assigned
2020-06-20 [email protected] [VM/Runtime] - Fix for issue dart-lang/sdk#42421
2020-06-20 [email protected] Added module information to metadata and use by frontend_sever
2020-06-19 [email protected] [ddc] Normalize T to Never when T extends Never
2020-06-19 [email protected] [dart:io] HttpClientConnection is destroyed for "CONNECT" request
2020-06-19 [email protected] [dart2js] Add support for Never as a type literal.
2020-06-19 [email protected] [dart2js] Visit type parameter bounds in the scope visitor.
2020-06-19 [email protected] Migrate language_2/type_promotion to NNBD.
2020-06-19 [email protected] Add CiderCompletionComputer.warmUp()
2020-06-19 [email protected] Fix duration.toString() to conform the description

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Closed
skia-flutter-autoroll added a commit to skia-flutter-autoroll/engine that referenced this issue Jun 21, 2020
@skia-flutter-autoroll
Roll Dart SDK from 9fcac03 to 32d403b (18 revisions)
607fa8c 
https://dart.googlesource.com/sdk.git/+log/9fcac032b669..32d403b472b5

2020-06-21 [email protected] Add a fix to insert the keyword late
2020-06-21 [email protected] Convert the remaining quick assists to use CorrectionProducer
2020-06-20 [email protected] Enable v1.9 pedantic lints...
2020-06-20 [email protected] Revert "Reland : [VM/Runtime] Cleanup package config initialization code"
2020-06-20 [email protected] [cfe] Mark late setters as isGenericCovariantImpl
2020-06-20 [email protected] Add --track-widget-creation to kernel_front_end.dart
2020-06-20 [email protected] [benchmark] BigIntParsePrint: Hoist value in all loops
2020-06-20 [email protected] Reland : [VM/Runtime] Cleanup package config initialization code
2020-06-20 [email protected] [dart2js] final locals may be assigned
2020-06-20 [email protected] [VM/Runtime] - Fix for issue dart-lang/sdk#42421
2020-06-20 [email protected] Added module information to metadata and use by frontend_sever
2020-06-19 [email protected] [ddc] Normalize T to Never when T extends Never
2020-06-19 [email protected] [dart:io] HttpClientConnection is destroyed for "CONNECT" request
2020-06-19 [email protected] [dart2js] Add support for Never as a type literal.
2020-06-19 [email protected] [dart2js] Visit type parameter bounds in the scope visitor.
2020-06-19 [email protected] Migrate language_2/type_promotion to NNBD.
2020-06-19 [email protected] Add CiderCompletionComputer.warmUp()
2020-06-19 [email protected] Fix duration.toString() to conform the description

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Closed
skia-flutter-autoroll added a commit to skia-flutter-autoroll/engine that referenced this issue Jun 22, 2020
@skia-flutter-autoroll
Roll Dart SDK from 9fcac03 to dbefbc3 (19 revisions)
3e6a1b6 
https://dart.googlesource.com/sdk.git/+log/9fcac032b669..dbefbc375376

2020-06-22 [email protected] [infra] Empty SDK commit to validate recipe changes
2020-06-21 [email protected] Add a fix to insert the keyword late
2020-06-21 [email protected] Convert the remaining quick assists to use CorrectionProducer
2020-06-20 [email protected] Enable v1.9 pedantic lints...
2020-06-20 [email protected] Revert "Reland : [VM/Runtime] Cleanup package config initialization code"
2020-06-20 [email protected] [cfe] Mark late setters as isGenericCovariantImpl
2020-06-20 [email protected] Add --track-widget-creation to kernel_front_end.dart
2020-06-20 [email protected] [benchmark] BigIntParsePrint: Hoist value in all loops
2020-06-20 [email protected] Reland : [VM/Runtime] Cleanup package config initialization code
2020-06-20 [email protected] [dart2js] final locals may be assigned
2020-06-20 [email protected] [VM/Runtime] - Fix for issue dart-lang/sdk#42421
2020-06-20 [email protected] Added module information to metadata and use by frontend_sever
2020-06-19 [email protected] [ddc] Normalize T to Never when T extends Never
2020-06-19 [email protected] [dart:io] HttpClientConnection is destroyed for "CONNECT" request
2020-06-19 [email protected] [dart2js] Add support for Never as a type literal.
2020-06-19 [email protected] [dart2js] Visit type parameter bounds in the scope visitor.
2020-06-19 [email protected] Migrate language_2/type_promotion to NNBD.
2020-06-19 [email protected] Add CiderCompletionComputer.warmUp()
2020-06-19 [email protected] Fix duration.toString() to conform the description

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
This was referenced Jun 22, 2020
Closed
Closed
skia-flutter-autoroll added a commit to skia-flutter-autoroll/engine that referenced this issue Jun 22, 2020
@skia-flutter-autoroll
Roll Dart SDK from 9fcac03 to ed0eeae (20 revisions)
82ba308 
https://dart.googlesource.com/sdk.git/+log/9fcac032b669..ed0eeaebcac2

2020-06-22 [email protected] [vm/aot] Move precompiled position handling to CodeSourceMap classes.
2020-06-22 [email protected] [infra] Empty SDK commit to validate recipe changes
2020-06-21 [email protected] Add a fix to insert the keyword late
2020-06-21 [email protected] Convert the remaining quick assists to use CorrectionProducer
2020-06-20 [email protected] Enable v1.9 pedantic lints...
2020-06-20 [email protected] Revert "Reland : [VM/Runtime] Cleanup package config initialization code"
2020-06-20 [email protected] [cfe] Mark late setters as isGenericCovariantImpl
2020-06-20 [email protected] Add --track-widget-creation to kernel_front_end.dart
2020-06-20 [email protected] [benchmark] BigIntParsePrint: Hoist value in all loops
2020-06-20 [email protected] Reland : [VM/Runtime] Cleanup package config initialization code
2020-06-20 [email protected] [dart2js] final locals may be assigned
2020-06-20 [email protected] [VM/Runtime] - Fix for issue dart-lang/sdk#42421
2020-06-20 [email protected] Added module information to metadata and use by frontend_sever
2020-06-19 [email protected] [ddc] Normalize T to Never when T extends Never
2020-06-19 [email protected] [dart:io] HttpClientConnection is destroyed for "CONNECT" request
2020-06-19 [email protected] [dart2js] Add support for Never as a type literal.
2020-06-19 [email protected] [dart2js] Visit type parameter bounds in the scope visitor.
2020-06-19 [email protected] Migrate language_2/type_promotion to NNBD.
2020-06-19 [email protected] Add CiderCompletionComputer.warmUp()
2020-06-19 [email protected] Fix duration.toString() to conform the description

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
skia-flutter-autoroll added a commit to skia-flutter-autoroll/engine that referenced this issue Jun 22, 2020
@skia-flutter-autoroll
Roll Dart SDK from 9fcac03 to 1d3fbbe (21 revisions)
97a8189 
https://dart.googlesource.com/sdk.git/+log/9fcac032b669..1d3fbbed7c06

2020-06-22 [email protected] Revert "Fix duration.toString() to conform the description"
2020-06-22 [email protected] [vm/aot] Move precompiled position handling to CodeSourceMap classes.
2020-06-22 [email protected] [infra] Empty SDK commit to validate recipe changes
2020-06-21 [email protected] Add a fix to insert the keyword late
2020-06-21 [email protected] Convert the remaining quick assists to use CorrectionProducer
2020-06-20 [email protected] Enable v1.9 pedantic lints...
2020-06-20 [email protected] Revert "Reland : [VM/Runtime] Cleanup package config initialization code"
2020-06-20 [email protected] [cfe] Mark late setters as isGenericCovariantImpl
2020-06-20 [email protected] Add --track-widget-creation to kernel_front_end.dart
2020-06-20 [email protected] [benchmark] BigIntParsePrint: Hoist value in all loops
2020-06-20 [email protected] Reland : [VM/Runtime] Cleanup package config initialization code
2020-06-20 [email protected] [dart2js] final locals may be assigned
2020-06-20 [email protected] [VM/Runtime] - Fix for issue dart-lang/sdk#42421
2020-06-20 [email protected] Added module information to metadata and use by frontend_sever
2020-06-19 [email protected] [ddc] Normalize T to Never when T extends Never
2020-06-19 [email protected] [dart:io] HttpClientConnection is destroyed for "CONNECT" request
2020-06-19 [email protected] [dart2js] Add support for Never as a type literal.
2020-06-19 [email protected] [dart2js] Visit type parameter bounds in the scope visitor.
2020-06-19 [email protected] Migrate language_2/type_promotion to NNBD.
2020-06-19 [email protected] Add CiderCompletionComputer.warmUp()
2020-06-19 [email protected] Fix duration.toString() to conform the description

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Closed
skia-flutter-autoroll added a commit to skia-flutter-autoroll/engine that referenced this issue Jun 22, 2020
@skia-flutter-autoroll
Roll Dart SDK from 9fcac03 to cc5df58 (22 revisions)
b049bfe 
https://dart.googlesource.com/sdk.git/+log/9fcac032b669..cc5df58bd229

2020-06-22 [email protected] [cfe] Refactor return type checking in preparation for nnbd spec change
2020-06-22 [email protected] Revert "Fix duration.toString() to conform the description"
2020-06-22 [email protected] [vm/aot] Move precompiled position handling to CodeSourceMap classes.
2020-06-22 [email protected] [infra] Empty SDK commit to validate recipe changes
2020-06-21 [email protected] Add a fix to insert the keyword late
2020-06-21 [email protected] Convert the remaining quick assists to use CorrectionProducer
2020-06-20 [email protected] Enable v1.9 pedantic lints...
2020-06-20 [email protected] Revert "Reland : [VM/Runtime] Cleanup package config initialization code"
2020-06-20 [email protected] [cfe] Mark late setters as isGenericCovariantImpl
2020-06-20 [email protected] Add --track-widget-creation to kernel_front_end.dart
2020-06-20 [email protected] [benchmark] BigIntParsePrint: Hoist value in all loops
2020-06-20 [email protected] Reland : [VM/Runtime] Cleanup package config initialization code
2020-06-20 [email protected] [dart2js] final locals may be assigned
2020-06-20 [email protected] [VM/Runtime] - Fix for issue dart-lang/sdk#42421
2020-06-20 [email protected] Added module information to metadata and use by frontend_sever
2020-06-19 [email protected] [ddc] Normalize T to Never when T extends Never
2020-06-19 [email protected] [dart:io] HttpClientConnection is destroyed for "CONNECT" request
2020-06-19 [email protected] [dart2js] Add support for Never as a type literal.
2020-06-19 [email protected] [dart2js] Visit type parameter bounds in the scope visitor.
2020-06-19 [email protected] Migrate language_2/type_promotion to NNBD.
2020-06-19 [email protected] Add CiderCompletionComputer.warmUp()
2020-06-19 [email protected] Fix duration.toString() to conform the description

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Merged
dart-bot pushed a commit that referenced this issue Jul 9, 2020
@sortie
[benchmark] Don't pass --sound-null-safety to dart_precompiled_runtime2.
c84c1cb 
The autodetection was fixed in bbc8aed,
so the workaround of passing --sound-null-safety to the AOT runtime is
no longer needed.

This change tests that the autodetection does in fact work.

Bug: #42421
Change-Id: Ibbe9665905e817a28964b698e6c437897c9dc6ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153771
Reviewed-by: Alexander Markov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-siva a-siva

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@a-siva @alexmarkov