[ddc] Run tests on canary and stable bots with matching settings

Closes: #53077
Towards: #43986
Change-Id: I60df13b8ff29a0865a45b3a48a97af0ce94460b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/317448
Reviewed-by: Nicholas Shahan <[email protected]>
Commit-Queue: Anna Gringauze <[email protected]>

Author: Anna Gringauze

pkg/dev_compiler/lib/src/kernel/compiler.dart

@@ -4546,23 +4546,41 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
       jsCondition = runtimeCall('test(#)', [jsCondition]);
     }
 
-    var encodedSource =
-        node.enclosingComponent!.uriToSource[node.location!.file]!.source;
-    var source = utf8.decode(encodedSource, allowMalformed: true);
-    var conditionSource =
-        source.substring(node.conditionStartOffset, node.conditionEndOffset);
-    var location = _toSourceLocation(node.conditionStartOffset)!;
+    SourceLocation? location;
+    late String conditionSource;
+    if (node.location != null) {
+      var encodedSource =
+          node.enclosingComponent!.uriToSource[node.location!.file]!.source;
+      var source = utf8.decode(encodedSource, allowMalformed: true);
+
+      conditionSource =
+          source.substring(node.conditionStartOffset, node.conditionEndOffset);
+      location = _toSourceLocation(node.conditionStartOffset)!;
+    } else {
+      // Location is null in expression compilation when modules
+      // are loaded from kernel using expression compiler worker.
+      // Show the error only in that case, with the condition AST
+      // instead of the source.
+      //
+      // TODO(annagrin): Can we add some information to the kernel,
+      // or add better printing for the condition?
+      // Issue: https://github.com/dart-lang/sdk/issues/43986
+      conditionSource = node.condition.toString();
+    }
     return js.statement(' if (!#) #;', [
       jsCondition,
       runtimeCall('assertFailed(#, #, #, #, #)', [
         if (node.message == null)
           js_ast.LiteralNull()
         else
           _visitExpression(node.message!),
-        _cacheUri(location.sourceUrl.toString()),
+        if (location == null)
+          _cacheUri('<unknown source>')
+        else
+          _cacheUri(location.sourceUrl.toString()),
         // Lines and columns are typically printed with 1 based indexing.
-        js.number(location.line + 1),
-        js.number(location.column + 1),
+        js.number(location == null ? -1 : location.line + 1),
+        js.number(location == null ? -1 : location.column + 1),
         js.escapedString(conditionSource),
       ])
     ]);

pkg/dev_compiler/lib/src/kernel/expression_compiler_worker.dart

@@ -84,6 +84,7 @@ class ExpressionCompilerWorker {
   final CompilerOptions _compilerOptions;
   final ModuleFormat _moduleFormat;
   final bool _canaryFeatures;
+  final bool _enableAsserts;
   final Component _sdkComponent;
 
   void Function()? onDone;
@@ -93,17 +94,13 @@ class ExpressionCompilerWorker {
     this._compilerOptions,
     this._moduleFormat,
     this._canaryFeatures,
+    this._enableAsserts,
     this._sdkComponent,
     this.requestStream,
     this.sendResponse,
     this.onDone,
   );
 
-  // Disable asserts due to failures to load source and locations on kernel
-  // loaded from dill files in DDC.
-  // https://github.com/dart-lang/sdk/issues/43986
-  static const bool _enableAsserts = false;
-
   /// Create expression compiler worker from [args] and start it.
   ///
   /// If [sendPort] is provided, creates a `receivePort` and sends it to
@@ -197,6 +194,7 @@ class ExpressionCompilerWorker {
       soundNullSafety: parsedArgs['sound-null-safety'] as bool,
       moduleFormat: moduleFormat,
       canaryFeatures: parsedArgs['canary'] as bool,
+      enableAsserts: parsedArgs['enable-asserts'] as bool,
       verbose: parsedArgs['verbose'] as bool,
       requestStream: requestStream,
       sendResponse: sendResponse,
@@ -223,6 +221,7 @@ class ExpressionCompilerWorker {
     bool soundNullSafety = false,
     ModuleFormat moduleFormat = ModuleFormat.amd,
     bool canaryFeatures = false,
+    bool enableAsserts = true,
     bool verbose = false,
     Stream<Map<String, dynamic>>? requestStream, // Defaults to read from stdin
     void Function(Map<String, dynamic>)?
@@ -242,7 +241,7 @@ class ExpressionCompilerWorker {
       ..omitPlatform = true
       ..environmentDefines = addGeneratedVariables({
         if (environmentDefines != null) ...environmentDefines,
-      }, enableAsserts: _enableAsserts)
+      }, enableAsserts: enableAsserts)
       ..explicitExperimentalFlags = explicitExperimentalFlags
       ..onDiagnostic = _onDiagnosticHandler(errors, warnings, infos)
       ..nnbdMode = soundNullSafety ? NnbdMode.Strong : NnbdMode.Weak
@@ -267,6 +266,7 @@ class ExpressionCompilerWorker {
         compilerOptions,
         moduleFormat,
         canaryFeatures,
+        enableAsserts,
         sdkComponent,
         requestStream,
         sendResponse,
@@ -451,8 +451,8 @@ class ExpressionCompilerWorker {
         summarizeApi: false,
         moduleName: moduleName,
         soundNullSafety: _compilerOptions.nnbdMode == NnbdMode.Strong,
-        enableAsserts: _enableAsserts,
         canaryFeatures: _canaryFeatures,
+        enableAsserts: _enableAsserts,
       ),
       _moduleCache.componentForLibrary,
       _moduleCache.moduleNameForComponent,
@@ -790,6 +790,13 @@ final argParser = ArgParser()
   ..addFlag('track-widget-creation', defaultsTo: false)
   ..addFlag('sound-null-safety', negatable: true, defaultsTo: true)
   ..addFlag('canary', negatable: true, defaultsTo: false)
+  // Disable asserts in compiled code by default, which is different
+  // from the default value of the setting in DDC.
+  //
+  // TODO(annagrin) Change the default to `true` after the user code
+  // is tested with enabled asserts.
+  // Issue: https://github.com/dart-lang/sdk/issues/43986
+  ..addFlag('enable-asserts', negatable: true, defaultsTo: false)
   ..addFlag('verbose', defaultsTo: false);
 
 Uri? _argToUri(String? uriArg) =>

pkg/dev_compiler/test/expression_compiler/assertions_enabled_test.dart

@@ -5,18 +5,23 @@
 import 'package:test/test.dart';
 
 import 'expression_compiler_e2e_suite.dart';
+import 'setup_compiler_options.dart';
 
-void main() async {
+void main(List<String> args) async {
   var driver = await TestDriver.init();
 
-  group('dart.web.assertions_enabled', () {
+  group('Assertions |', () {
     const source = r'''
       void main() {
         var b = const bool.fromEnvironment('dart.web.assertions_enabled');
 
         // Breakpoint: bp
         print('hello world');
       }
+      int myAssert() {
+        assert(false);
+        return 0;
+      }
     ''';
 
     tearDown(() async {
@@ -27,19 +32,52 @@ void main() async {
       await driver.finish();
     });
 
-    test('is automatically set', () async {
-      var setup = SetupCompilerOptions(enableAsserts: true);
+    test('dart.web.assertions_enabled is set when asserts are enabled',
+        () async {
+      var setup = SetupCompilerOptions(args: args);
+      await driver.initSource(setup, source);
+
+      await driver.check(
+          breakpointId: 'bp',
+          expression: 'b',
+          expectedResult: '${setup.enableAsserts}');
+    });
+
+    test('assert errors in the source code when asserts are enabled', () async {
+      var setup = SetupCompilerOptions(args: args);
       await driver.initSource(setup, source);
-      // TODO(43986): Update when assertions are enabled.
+
       await driver.check(
-          breakpointId: 'bp', expression: 'b', expectedResult: 'false');
+        breakpointId: 'bp',
+        expression: 'myAssert()',
+        expectedResult: setup.enableAsserts
+            ? allOf(
+                contains('Error: Assertion failed:'),
+                contains('test.dart:8:16'),
+                contains('false'),
+                contains('is not true'),
+              )
+            : '0',
+      );
     });
 
-    test('is automatically unset', () async {
-      var setup = SetupCompilerOptions(enableAsserts: false);
+    test('assert errors in evaluated expression when asserts are enabled',
+        () async {
+      var setup = SetupCompilerOptions(args: args);
       await driver.initSource(setup, source);
+
       await driver.check(
-          breakpointId: 'bp', expression: 'b', expectedResult: 'false');
+        breakpointId: 'bp',
+        expression: '() { assert(false); return 0; } ()',
+        expectedResult: setup.enableAsserts
+            ? allOf(
+                contains('Error: Assertion failed:'),
+                contains('<unknown source>:-1:-1'),
+                contains('BoolLiteral(false)'),
+                contains('is not true'),
+              )
+            : '0',
+      );
     });
   });
 }

pkg/dev_compiler/test/expression_compiler/canary_features_enabled_test.dart

@@ -0,0 +1,41 @@
+// Copyright (c) 2023, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:io';
+
+import 'package:test/test.dart';
+
+import 'expression_compiler_e2e_suite.dart';
+import 'setup_compiler_options.dart';
+
+void main(List<String> args) async {
+  var driver = await TestDriver.init();
+
+  group('canary', () {
+    const source = r'''
+      void main() {
+        print('hello world');
+      }
+    ''';
+
+    tearDown(() async {
+      await driver.cleanupTest();
+    });
+
+    tearDownAll(() async {
+      await driver.finish();
+    });
+
+    test('is automatically set to the configuration value', () async {
+      var setup = SetupCompilerOptions(args: args);
+      await driver.initSource(setup, source);
+
+      expect(
+          File(driver.dartSdkPath).readAsStringSync(),
+          setup.canaryFeatures
+              ? contains('canary')
+              : isNot(contains('canary')));
+    });
+  });
+}

pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_amd_agnostic_sound_shard_1_test.dart

@@ -8,8 +8,9 @@ import 'package:test/test.dart';
 
 import 'expression_compiler_e2e_shared.dart';
 import 'expression_compiler_e2e_suite.dart';
+import 'setup_compiler_options.dart';
 
-void main() async {
+void main(List<String> args) async {
   var driver = await TestDriver.init();
 
   group('(Sound null safety) (Agnostic code shard 1)', () {
@@ -19,9 +20,11 @@ void main() async {
 
     group('(AMD module system)', () {
       var setup = SetupCompilerOptions(
-          soundNullSafety: true,
-          legacyCode: false,
-          moduleFormat: ModuleFormat.amd);
+        soundNullSafety: true,
+        legacyCode: false,
+        moduleFormat: ModuleFormat.amd,
+        args: args,
+      );
       runAgnosticSharedTestsShard1(setup, driver);
     });
   });

pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_amd_agnostic_sound_shard_2_test.dart

@@ -8,8 +8,9 @@ import 'package:test/test.dart';
 
 import 'expression_compiler_e2e_shared.dart';
 import 'expression_compiler_e2e_suite.dart';
+import 'setup_compiler_options.dart';
 
-void main() async {
+void main(List<String> args) async {
   var driver = await TestDriver.init();
 
   group('(Sound null safety) (Agnostic code shard 2)', () {
@@ -19,9 +20,11 @@ void main() async {
 
     group('(AMD module system)', () {
       var setup = SetupCompilerOptions(
-          soundNullSafety: true,
-          legacyCode: false,
-          moduleFormat: ModuleFormat.amd);
+        soundNullSafety: true,
+        legacyCode: false,
+        moduleFormat: ModuleFormat.amd,
+        args: args,
+      );
       runAgnosticSharedTestsShard2(setup, driver);
     });
   });

pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_amd_agnostic_unsound_shard_1_test.dart

@@ -8,8 +8,9 @@ import 'package:test/test.dart';
 
 import 'expression_compiler_e2e_shared.dart';
 import 'expression_compiler_e2e_suite.dart';
+import 'setup_compiler_options.dart';
 
-void main() async {
+void main(List<String> args) async {
   var driver = await TestDriver.init();
 
   group('(Unsound null safety) (Agnostic code shard 1)', () {
@@ -19,9 +20,11 @@ void main() async {
 
     group('(AMD module system)', () {
       var setup = SetupCompilerOptions(
-          soundNullSafety: false,
-          legacyCode: false,
-          moduleFormat: ModuleFormat.amd);
+        soundNullSafety: false,
+        legacyCode: false,
+        moduleFormat: ModuleFormat.amd,
+        args: args,
+      );
       runAgnosticSharedTestsShard1(setup, driver);
     });
   });

pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_amd_agnostic_unsound_shard_2_test.dart

@@ -8,8 +8,9 @@ import 'package:test/test.dart';
 
 import 'expression_compiler_e2e_shared.dart';
 import 'expression_compiler_e2e_suite.dart';
+import 'setup_compiler_options.dart';
 
-void main() async {
+void main(List<String> args) async {
   var driver = await TestDriver.init();
 
   group('(Unsound null safety) (Agnostic code shard 2)', () {
@@ -19,9 +20,11 @@ void main() async {
 
     group('(AMD module system)', () {
       var setup = SetupCompilerOptions(
-          soundNullSafety: false,
-          legacyCode: false,
-          moduleFormat: ModuleFormat.amd);
+        soundNullSafety: false,
+        legacyCode: false,
+        moduleFormat: ModuleFormat.amd,
+        args: args,
+      );
       runAgnosticSharedTestsShard2(setup, driver);
     });
   });

pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_amd_legacy_shard_1_test.dart

@@ -8,8 +8,9 @@ import 'package:test/test.dart';
 
 import 'expression_compiler_e2e_shared.dart';
 import 'expression_compiler_e2e_suite.dart';
+import 'setup_compiler_options.dart';
 
-void main() async {
+void main(List<String> args) async {
   var driver = await TestDriver.init();
 
   group('(Legacy code shard 1)', () {
@@ -19,9 +20,11 @@ void main() async {
 
     group('(AMD module system)', () {
       var setup = SetupCompilerOptions(
-          soundNullSafety: false,
-          legacyCode: true,
-          moduleFormat: ModuleFormat.amd);
+        soundNullSafety: false,
+        legacyCode: true,
+        moduleFormat: ModuleFormat.amd,
+        args: args,
+      );
       runAgnosticSharedTestsShard1(setup, driver);
     });
   });