[ddc] run expression evaluation canary tests on canary bots #53077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

annagrin opened this issue Jul 31, 2023 · 0 comments

Labels

area-web-js web-dev-compiler web-eval

Contributor

annagrin commented Jul 31, 2023

The canary js files are currently compiled into a different directory from the stable ones, and expression evaluation tests do not account for that.

Make sure expression evaluation suite can find dart_sdk.js based on the mode (canary/stable)
Split the expression evaluation tests into canary and stable ones
Make sure stable and canary bots only run appropriate tests

annagrin added web-dev-compiler web-eval labels

annagrin mentioned this issue

Update dwds for new DDC type system dart-lang/webdev#1949

Closed

10 tasks

lrhn added the area-web-js label

copybara-service bot closed this as completed in

dd1e7ae

annagrin changed the title ~~[ddc] run canary tests on canary bots~~ [ddc] run expression evaluation canary tests on canary bots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment