Skip to content

Update dwds for new DDC type system #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
10 tasks done
annagrin opened this issue Feb 10, 2023 · 2 comments
Closed
10 tasks done

Update dwds for new DDC type system #1949

annagrin opened this issue Feb 10, 2023 · 2 comments
Assignees

Comments

@annagrin
Copy link
Contributor

annagrin commented Feb 10, 2023

New type system tracking issue: dart-lang/sdk#48585

We use old logic in many places in dwds, for example, for determining the object's runtime kind here:

const isFunction = sdkUtils.AbstractFunctionType.is(classObject);

The logic will break with the new types system. Make sure that dwds can handle both cases (and roll internally) before flipping the flag that enables new type system in ddc.

Work tracking:

SDK

build_web_compilers

DWDS

@annagrin
Copy link
Contributor Author

@nshahan this should be blocking flipping the new type system flag in ddc.
@elliette FYI

@bkonyi
Copy link
Collaborator

bkonyi commented Aug 14, 2024

It looks like all referenced issues here are closed, so I'm just going to close this.

@bkonyi bkonyi closed this as completed Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants