Skip to content

Run instance tests with frontend server #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 5, 2023
Merged

Run instance tests with frontend server #2160

merged 11 commits into from
Jul 5, 2023

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Jun 26, 2023 •
edited
Loading

We were running instance_test.dart only with build daemon compilation.
Running instance tests with frontend server required specifying the basePath via the asset reader. (Previous automatic basePath discovery was not correct for the instance tests).

In this PR:

  • remove automatic discovery of basePath in dev_handler.dart.
  • require AssetReader to provide a base path
  • manually verified that flutter tools work with the changes in dwds.
  • updated major version due to the dwds API change.

Closes: #2158

@annagrin annagrin mentioned this pull request Jun 23, 2023
Closed
10 tasks
@annagrin annagrin requested a review from elliette June 26, 2023 20:24
annagrin
annagrin commented Jun 26, 2023
View reviewed changes
elliette
elliette reviewed Jun 26, 2023
View reviewed changes
elliette
elliette approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion but LGTM!

@annagrin annagrin requested a review from elliette June 28, 2023 20:27
elliette
elliette reviewed Jun 28, 2023
View reviewed changes
elliette
elliette reviewed Jun 28, 2023
View reviewed changes
elliette
elliette approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved!

@annagrin annagrin merged commit cbb0d76 into dart-lang:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliette elliette elliette approved these changes

Assignees
No one assigned
Labels
package:dwds run-dcm-workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run instance_test.dart with frontend server
2 participants
@annagrin @elliette